Running Software (issues missing this information will be deleted):
Addon version: PetTracker-10.0-10.0.0.zip
Server patch: 10.0.0[46366] x64
Have you read the changelog? (please don't waste our time)
Yes
Describe the bug
When challenging any pet tamer, the log below is displayed in a popup.
Once the tamer is defeated, the popup doesn't show when clicked again.
To Reproduce
Steps to reproduce the behaviour:
Go to any pet tamer( ex. Major Payne in Northrend)
Click on them
error popup
Expected behaviour
The popup shouldn't appear.
Screenshots
Error Logs
Message: ...ce/AddOns/PetTracker/addons/main/features/gossip.lua:28: attempt to call global 'GossipFrame_GetTitleButtonCount' (a nil value)
Time: Wed Nov 2 07:40:06 2022
Count: 1
Stack: ...ce/AddOns/PetTracker/addons/main/features/gossip.lua:28: attempt to call global 'GossipFrame_GetTitleButtonCount' (a nil value)
[string "@Interface/AddOns/PetTracker/addons/main/features/gossip.lua"]:28: in function <...ce/AddOns/PetTracker/addons/main/features/gossip.lua:23>
[string "=[C]"]: in function Update' [string "@Interface/FrameXML/GossipFrame.lua"]:66: in functionHandleShow'
[string "@Interface/FrameXML/CustomGossipFrameBase.lua"]:47: in function `HandleOpenEvent'
[string "@Interface/FrameXML/CustomGossipFrameBase.lua"]:39: in function <Interface/FrameXML/CustomGossipFrameBase.lua:37>
Locals: unit = "Creature-0-1465-571-51-66675-000061C9C3"
id = 66675
(temporary) = nil
(temporary) = "attempt to call global 'GossipFrameGetTitleButtonCount' (a nil value)"
Addon =
{
Gossip =
{
}
Enemy =
{
}
GetColor = defined @Interface/AddOns/PetTracker/addons/main/main.lua:66
Species =
{
}
Rival =
{
}
OnPetsChanged = defined @Interface/AddOns/PetTracker/addons/main/main.lua:53
Tracker =
{
}
Search = defined @Interface/AddOns/PetTracker/addons/main/api/search.lua:26
RivalInfo =
{
}
Delay = defined @Interface/AddOns/PetTracker/libs/MutexDelay-1.0/MutexDelay-1.0.lua:27
MultiTip =
{
}
RegisterMessage = defined @Interface/AddOns/AllTheThings/lib/CallbackHandler-1.0/CallbackHandler-1.0.lua:90
UnregisterMessage = defined @Interface/AddOns/AllTheThings/lib/CallbackHandler-1.0/CallbackHandler-1.0.lua:153
Rivals =
{
}
Base =
{
}
UnregisterSignal = defined @Interface/AddOns/PetTracker/libs/WildAddon-1.0/WildAddon-1.0.lua:78
SpecieBreeds =
{
}
RegisterEvent = defined @Interface/AddOns/AllTheThings/lib/CallbackHandler-1.0/CallbackHandler-1.0.lua:90
sets =
{
}
OnBattle = defined @Interface/AddOns/PetTracker/addons/main/main.lua:57
AbilityButton =
{
}
OnEnable = defined @Interface/AddOns/PetTracker/addons/main/main.lua:26
Name = "PetTracker"
BattleSlot =
{
}
UnregisterAllEvents = defined @Interface/AddOns/AllTheThings/lib/CallbackHandler-1.0/CallbackHandler-1.0.lua:174
AbilityAction =
{
}
JournalMods =
{
}
RegisterSignal = defined @Interface/AddOns/PetTracker/libs/WildAddon-1.0/WildAddon-1.0.lua:74
UnregisterAllMessages = defined @Interface/AddOns/AllTheThings/lib/CallbackHandler-1.0/CallbackHandler-1.0.lua:174
Pet =
{
}
state =
{
}
Delaying = defined @Interface/AddOns/PetTracker/libs/MutexDelay-1.0/MutexDelay-1.0.lua:46
Tooltips =
{
}
Predict =
{
}
MaxQuality = 6
Specie =
{
}
Ability =
{
}
UnregisterEvent = defined @Interface/AddOns/AllTheThings/lib
Additional context
Add any other context about the problem here.
The correct fix for this is in #312 - instead of checking if the function exists (which it never will), just change it to use the correct function instead.
Running Software (issues missing this information will be deleted):
Server patch: 10.0.0[46366] x64
Have you read the changelog? (please don't waste our time) Yes
Describe the bug When challenging any pet tamer, the log below is displayed in a popup. Once the tamer is defeated, the popup doesn't show when clicked again.
To Reproduce Steps to reproduce the behaviour:
Expected behaviour The popup shouldn't appear.
Screenshots![image](https://user-images.githubusercontent.com/28352648/199431145-0d0011f5-5c23-49ed-8734-a765eb1aafdd.png)
Error Logs