search

Jaliborc / PetTracker

Tracks pets, alerts for upgrades and helps you in pet battles.
47 stars 25 forks source link

Add check if function GossipFrame_GetTitleButtonCount exists. #308

Closed terrybader closed 1 year ago

terrybader commented 1 year ago

Fix for #299 error on call to function GossipFrame_GetTitleButtonCount() which does not exists.

vttale commented 1 year ago

While the change would make the error go away, I'm wondering what this block of code is really for, and where GossipFrame_GetTitleButtonCount is meant to be coming from. If it's a Blizzard function that just doesn't exist anymore, then the whole block being removed is more correct than the check for nil wrapper. If it is from a missing dependency, that dependency needs included. If the functionality here is desired, then it should be updated to use whatever the appropriate Dragonflight method is.

For now I too am just returning from the function to stop the error, but what functionality is being thwarted?

Jaliborc commented 1 year ago

This just disables the gossip functionality. Error goes away because no code is run.