Jaliborc / PetTracker

Tracks pets, alerts for upgrades and helps you in pet battles.
47 stars 25 forks source link

10.0.2 Error #311

Closed Masumia closed 1 year ago

Masumia commented 1 year ago

Running Software (issues missing this information will be deleted):

Describe the bug Click on a pet trainer, bug happens

To Reproduce Steps to reproduce the behaviour:

  1. Go to any pet trainer
  2. Click on trainer
  3. See error

Expected behaviour No error should happen when clicking on trainer

Error Logs 1x ...ce/AddOns/PetTracker/addons/main/features/gossip.lua:28: attempt to call global 'GossipFrame_GetTitleButtonCount' (a nil value) [string "@Interface/AddOns/PetTracker/addons/main/features/gossip.lua"]:28: in function <...ce/AddOns/PetTracker/addons/main/features/gossip.lua:23> [string "=[C]"]: in function Update' [string "@Interface/FrameXML/GossipFrame.lua"]:66: in functionHandleShow' [string "@Interface/FrameXML/CustomGossipFrameBase.lua"]:47: in function `HandleOpenEvent' [string "@Interface/FrameXML/CustomGossipFrameBase.lua"]:39: in function <Interface/FrameXML/CustomGossipFrameBase.lua:37>

Locals: unit = "Creature-0-3885-1116-22-87122-00007418A9" id = 87122 (temporary) = nil (temporary) = "attempt to call global 'GossipFrameGetTitleButtonCount' (a nil value)" Addon =

{ SendSignal = defined @Interface/AddOns/PetTracker/libs/WildAddon-1.0/WildAddon-1.0.lua:82 Gossip =
{ } SpeciePin =
{ } UnregisterAllEvents = defined @Interface/AddOns/AllTheThings/lib/CallbackHandler-1.0/CallbackHandler-1.0.lua:174 Enemy =
{ } sets =
{ } state =
{ } MaxLevel = 25 GetColor = defined @Interface/AddOns/PetTracker/addons/main/main.lua:66 Entity =
{ } Species =
{ } Delaying = defined @Interface/AddOns/PetTracker/libs/MutexDelay-1.0/MutexDelay-1.0.lua:46 JournalSlot =
{ } Rival =
{ } Tooltips =
{ } OnPetsChanged = defined @Interface/AddOns/PetTracker/addons/main/main.lua:53 NewModule = defined @Interface/AddOns/PetTracker/libs/WildAddon-1.0/WildAddon-1.0.lua:68 MultiTip =
{ } MapCanvas =
{ } Tracker =
{ } Stables =
{ } AbilityDisplay =
{ } TextLine =
{ } Search = defined @Interface/AddOns/PetTracker/addons/main/api/search.lua:26 StablePin =
{ } RivalInfo =
{ } Pin =
{ } Delay = defined @Interface/AddOns/PetTracker/libs/MutexDelay-1.0/MutexDelay-1.0.lua:27 Tag = "PETTRACKER" BattleSlot =
{ } Pet =
{ } AbilityAction =
{ } TextList =
{ } MaxQuality = 6 UnregisterMessage = defined @Interface/AddOns/AllTheThings/lib/CallbackHandler-1.0/CallbackHandler-1.0.lua:153 ProgressBar =
{ } SpecieStats =
{ } RivalPin =
{ } MapSearch =
{ } Specie =
{ } PetSlot =
{ } Ability =
{ } Rivals =
{ } Base =
{ } Predict =
{ } UnregisterSignal = defined @Interface/AddOns/PetTracker/libs/WildAddon-1.0/WildAddon-1.0.lua:78 Maps =
{ } SpecieBreeds =
{ } RegisterMessage = defined @Interface/AddOns/AllTheThings/lib/CallbackHandler-1.0/CallbackHandler-1.0.lua:90 RegisterEvent = defined @Interface/AddOns/AllTheThings/lib/CallbackHandler-1.0/CallbackHandler-1.0.lua:90 UnregisterAllMessages = defined @Interface/AddOns/AllTheThings/lib/CallbackHandler-1.0/CallbackHandler-1.0.lua:174 OnBattle = defined @Interface/AddOns/PetTracker/addons/main/main.lua:57 Breeds =
{ } AbilityButton =
{ } OnEnable = defined @Interface/AddOns/PetTracker/addons/main/main.lua:26 Name = "PetTracker" RivalOrder =
{ } SendMessage = defined @Interface/AddOns/AllTheThings/lib/CallbackHandler-1.0/CallbackHandler-1.0.lua:59 RegisterSignal = defined @Interface/AddOns/PetTracker/libs/WildAddon-1.0/WildAddon-1.0.lua:74 UnregisterEvent = defined @Interface/AddOns/AllTheThings/lib/CallbackHandler-1.0/CallbackHandler-1.0.lua:153 Objectives = Frame { } } L =
{ Switcher = "Switcher" Tutorial =
{ } BreedExplanation = "Determines how stats gained at each level are distributed." FAQDescription = "These are the most frequently asked questions. To see the tutorials again, reset the addon settings using the "Defaults" button at the lower left corner." FilterSpecies = "Filter Species" Species = "Species" OptionsDescription = "These options allow you to toggle PetTracker general features on and off. Gotta catch them all!" Maximized = "Maximized" SpecieIconsTip = "If disabled, pets will be marked by their type instead of species when shown in the world and battle map." TotalRivals = "Total Rivals" Ninja = "Ninja" AddWaypoint = "Add Waypoint" AvailableBreeds = "Available Breeds" ShowStables = "Show Stables" Breed = "Breed" Source8 = "Promotion" TellMore = "Tell me more about yourself." AlertUpgrades = "Alert for Upgrades" NoneCollected = "None Collected" EnemyTeam = "Enemy Team" S

GurliGebis commented 1 year ago

This issue is a duplicate of #299. The fix is in PR #312

GurliGebis commented 1 year ago

The correct fix for this is in #312 - instead of checking if the function exists (which it never will), just change it to use the correct function instead.

GurliGebis commented 1 year ago

My bad, it seems like #308 is better until a better solution can be found.