search

Jaliborc / PetTracker

Tracks pets, alerts for upgrades and helps you in pet battles.
47 stars 25 forks source link

Pet Tracker Welcome Message Popup #319

Closed Sylzana closed 1 year ago

Sylzana commented 1 year ago

Running Software (issues missing this information will be deleted):

Describe the bug On every login and reload, I get a welcome message with back and next button that do not work. Every single time.

To Reproduce Steps to reproduce the behaviour:

  1. Start or Reload Game

Expected behaviour Welcome message for first time start or after an update. Alternatively an option to disable the function would be fine too.

Screenshots WoWScrnShot_120722_154110

Error Logs After Start

Message: ...ker/libs/CustomTutorials-2.1/CustomTutorials-2.1.lua:55: attempt to index field 'TitleText' (a nil value)
Time: Wed Dec  7 15:42:58 2022
Count: 1
Stack: ...ker/libs/CustomTutorials-2.1/CustomTutorials-2.1.lua:55: attempt to index field 'TitleText' (a nil value)
[string "@Interface/AddOns/PetTracker/libs/CustomTutorials-2.1/CustomTutorials-2.1.lua"]:55: in function <...ker/libs/CustomTutorials-2.1/CustomTutorials-2.1.lua:36>
[string "@Interface/AddOns/PetTracker/libs/CustomTutorials-2.1/CustomTutorials-2.1.lua"]:199: in function `TriggerTutorial'
[string "@Interface/AddOns/PetTracker/addons/config/tutorials.lua"]:36: in function `Start'
[string "@Interface/AddOns/PetTracker/addons/config/tutorials.lua"]:28: in function `?'
[string "@Interface/AddOns/PetTracker/libs/WildAddon-1.0/WildAddon-1.0.lua"]:20: in function <...dOns/PetTracker/libs/WildAddon-1.0/WildAddon-1.0.lua:18>
[string "@Interface/AddOns/PetTracker/libs/WildAddon-1.0/WildAddon-1.0.lua"]:56: in function <...dOns/PetTracker/libs/WildAddon-1.0/WildAddon-1.0.lua:53>
[string "=[C]"]: ?
[string "@Interface/AddOns/PetTracker/libs/CallbackHandler-1.0/CallbackHandler-1.0.lua"]:29: in function <...ker/libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:25>
[string "@Interface/AddOns/PetTracker/libs/CallbackHandler-1.0/CallbackHandler-1.0.lua"]:64: in function `Fire'
[string "@Interface/AddOns/PetTracker/libs/AceEvent-3.0/AceEvent-3.0.lua"]:120: in function <...AddOns/PetTracker/libs/AceEvent-3.0/AceEvent-3.0.lua:119>
[string "=[C]"]: in function `LoadAddOn'
[string "@Interface/AddOns/PetTracker/addons/main/main.lua"]:46: in function `?'
[string "@Interface/AddOns/PetTracker/libs/WildAddon-1.0/WildAddon-1.0.lua"]:20: in function <...dOns/PetTracker/libs/WildAddon-1.0/WildAddon-1.0.lua:18>
[string "@Interface/AddOns/PetTracker/libs/WildAddon-1.0/WildAddon-1.0.lua"]:56: in function <...dOns/PetTracker/libs/WildAddon-1.0/WildAddon-1.0.lua:53>
[string "=[C]"]: ?
[string "@Interface/AddOns/PetTracker/libs/CallbackHandler-1.0/CallbackHandler-1.0.lua"]:29: in function <...ker/libs/CallbackHandler-1.0/CallbackHandler-1.0.lua:25>
[string "@Interface/AddOns/PetTracker/libs/CallbackHandler-1.0/CallbackHandler-1.0.lua"]:64: in function `Fire'
[string "@Interface/AddOns/PetTracker/libs/AceEvent-3.0/AceEvent-3.0.lua"]:120: in function <...AddOns/PetTracker/libs/AceEvent-3.0/AceEvent-3.0.lua:119>
[string "=[C]"]: in function `LoadAddOn'
[string "@Interface/FrameXML/UIParent.lua"]:536: in function `UIParentLoadAddOn'
[string "@Interface/FrameXML/UIParent.lua"]:667: in function `TimeManager_LoadUI'
[string "@Interface/FrameXML/UIParent.lua"]:1482: in function <Interface/FrameXML/UIParent.lua:1362>

Locals: <none>

After click on Back (Zurück)

Message: ...ker/libs/CustomTutorials-2.1/CustomTutorials-2.1.lua:115: attempt to perform arithmetic on field 'i' (a nil value)
Time: Wed Dec  7 15:45:47 2022
Count: 2
Stack: ...ker/libs/CustomTutorials-2.1/CustomTutorials-2.1.lua:115: attempt to perform arithmetic on field 'i' (a nil value)
[string "@Interface/AddOns/PetTracker/libs/CustomTutorials-2.1/CustomTutorials-2.1.lua"]:115: in function <...ker/libs/CustomTutorials-2.1/CustomTutorials-2.1.lua:114>

Locals: (*temporary) = <function> defined @Interface/AddOns/PetTracker/libs/CustomTutorials-2.1/CustomTutorials-2.1.lua:36
(*temporary) = CustomTutorials1 {
 0 = <userdata>
 images = <table> {
 }
 SetPortraitShown = <function> defined @Interface/SharedXML/PortraitFrame.lua:91
 GetTitleText = <function> defined @Interface/SharedXML/PortraitFrame.lua:28
 Inset = CustomTutorials1Inset {
 }
 SetPortraitTextureRaw = <function> defined @Interface/SharedXML/PortraitFrame.lua:79
 next = Button {
 }
 text = FontString {
 }
 TitleContainer = Frame {
 }
 SetTitleMaxLinesAndHeight = <function> defined @Interface/SharedXML/PortraitFrame.lua:49
 SetTitleColor = <function> defined @Interface/SharedXML/PortraitFrame.lua:32
 prev = Button {
 }
 shine = Frame {
 }
 DefaultPortraitTextureSizeAndOffset = <function> defined @Interface/SharedXML/PortraitFrame.lua:101
 SetTitle = <function> defined @Interface/SharedXML/PortraitFrame.lua:36
 SetBorder = <function> defined @Interface/SharedXML/PortraitFrame.lua:62
 layoutType = "PortraitFrameTemplate"
 flash = AnimationGroup {
 }
 SetPortraitToBag = <function> defined @Interface/SharedXML/PortraitFrame.lua:75
 PortraitContainer = Frame {
 }
 SetPortraitToUnit = <function> defined @Interface/SharedXML/PortraitFrame.lua:71
 Bg = CustomTutorials1Bg {
 }
 GetPortrait = <function> defined @Interface/SharedXML/PortraitFrame.lua:58
 SetTitleFormatted = <function> defined @Interface/SharedXML/PortraitFrame.lua:40
 NineSlice = Frame {
 }
 TopTileStreaks = Texture {
 }
 SetPortraitToAsset = <function> defined @Interface/SharedXML/PortraitFrame.lua:67
 SetPortraitTextureSizeAndOffset = <function> defined @Interface/SharedXML/PortraitFrame.lua:95
 CloseButton = CustomTutorials1CloseButton {
 }
 unlocked = 4
 data = <table> {
 }
 SetPortraitAtlasRaw = <function> defined @Interface/SharedXML/PortraitFrame.lua:83
 SetPortraitTexCoord = <function> defined @Interface/SharedXML/PortraitFrame.lua:87
}
(*temporary) = nil
(*temporary) = -1
(*temporary) = "attempt to perform arithmetic on field 'i' (a nil value)"
UpdateFrame = <function> defined @Interface/AddOns/PetTracker/libs/CustomTutorials-2.1/CustomTutorials-2.1.lua:36
frame = CustomTutorials1 {
 0 = <userdata>
 images = <table> {
 }
 SetPortraitShown = <function> defined @Interface/SharedXML/PortraitFrame.lua:91
 GetTitleText = <function> defined @Interface/SharedXML/PortraitFrame.lua:28
 Inset = CustomTutorials1Inset {
 }
 SetPortraitTextureRaw = <function> defined @Interface/SharedXML/PortraitFrame.lua:79
 next = Button {
 }
 text = FontString {
 }
 TitleContainer = Frame {
 }
 SetTitleMaxLinesAndHeight = <function> defined @Interface/SharedXML/PortraitFrame.lua:49
 SetTitleColor = <function> defined @Interface/SharedXML/PortraitFrame.lua:32
 prev = Button {
 }
 shine = Frame {
 }
 DefaultPortraitTextureSizeAndOffset = <function> defined @Interface/SharedXML/PortraitFrame.lua:101
 SetTitle = <function> defined @Interface/SharedXML/PortraitFrame.lua:36
 SetBorder = <function> defined @Interface/SharedXML/PortraitFrame.lua:62
 layoutType = "PortraitFrameTemplate"
 flash = AnimationGroup {
 }
 SetPortraitToBag = <function> defined @Interface/SharedXML/PortraitFrame.lua:75
 PortraitContainer = Frame {
 }
 SetPortraitToUnit = <function> defined @Interface/SharedXML/PortraitFrame.lua:71
 Bg = CustomTutorials1Bg {
 }
 GetPortrait = <function> defined @Interface/SharedXML/PortraitFrame.lua:58
 SetTitleFormatted = <function> defined @Interface/SharedXML/PortraitFrame.lua:40
 NineSlice = Frame {
 }
 TopTileStreaks = Textu

After click on Next (Weiter)

Message: ...ker/libs/CustomTutorials-2.1/CustomTutorials-2.1.lua:115: attempt to perform arithmetic on field 'i' (a nil value)
Time: Wed Dec  7 15:47:05 2022
Count: 1
Stack: ...ker/libs/CustomTutorials-2.1/CustomTutorials-2.1.lua:115: attempt to perform arithmetic on field 'i' (a nil value)
[string "@Interface/AddOns/PetTracker/libs/CustomTutorials-2.1/CustomTutorials-2.1.lua"]:115: in function <...ker/libs/CustomTutorials-2.1/CustomTutorials-2.1.lua:114>

Locals: (*temporary) = <function> defined @Interface/AddOns/PetTracker/libs/CustomTutorials-2.1/CustomTutorials-2.1.lua:36
(*temporary) = CustomTutorials1 {
 0 = <userdata>
 images = <table> {
 }
 SetPortraitShown = <function> defined @Interface/SharedXML/PortraitFrame.lua:91
 GetTitleText = <function> defined @Interface/SharedXML/PortraitFrame.lua:28
 Inset = CustomTutorials1Inset {
 }
 SetPortraitTextureRaw = <function> defined @Interface/SharedXML/PortraitFrame.lua:79
 next = Button {
 }
 text = FontString {
 }
 TitleContainer = Frame {
 }
 SetTitleMaxLinesAndHeight = <function> defined @Interface/SharedXML/PortraitFrame.lua:49
 SetTitleColor = <function> defined @Interface/SharedXML/PortraitFrame.lua:32
 prev = Button {
 }
 shine = Frame {
 }
 DefaultPortraitTextureSizeAndOffset = <function> defined @Interface/SharedXML/PortraitFrame.lua:101
 SetTitle = <function> defined @Interface/SharedXML/PortraitFrame.lua:36
 SetBorder = <function> defined @Interface/SharedXML/PortraitFrame.lua:62
 layoutType = "PortraitFrameTemplate"
 flash = AnimationGroup {
 }
 SetPortraitToBag = <function> defined @Interface/SharedXML/PortraitFrame.lua:75
 PortraitContainer = Frame {
 }
 SetPortraitToUnit = <function> defined @Interface/SharedXML/PortraitFrame.lua:71
 Bg = CustomTutorials1Bg {
 }
 GetPortrait = <function> defined @Interface/SharedXML/PortraitFrame.lua:58
 SetTitleFormatted = <function> defined @Interface/SharedXML/PortraitFrame.lua:40
 NineSlice = Frame {
 }
 TopTileStreaks = Texture {
 }
 SetPortraitToAsset = <function> defined @Interface/SharedXML/PortraitFrame.lua:67
 SetPortraitTextureSizeAndOffset = <function> defined @Interface/SharedXML/PortraitFrame.lua:95
 CloseButton = CustomTutorials1CloseButton {
 }
 unlocked = 4
 data = <table> {
 }
 SetPortraitAtlasRaw = <function> defined @Interface/SharedXML/PortraitFrame.lua:83
 SetPortraitTexCoord = <function> defined @Interface/SharedXML/PortraitFrame.lua:87
}
(*temporary) = nil
(*temporary) = 1
(*temporary) = "attempt to perform arithmetic on field 'i' (a nil value)"
UpdateFrame = <function> defined @Interface/AddOns/PetTracker/libs/CustomTutorials-2.1/CustomTutorials-2.1.lua:36
frame = CustomTutorials1 {
 0 = <userdata>
 images = <table> {
 }
 SetPortraitShown = <function> defined @Interface/SharedXML/PortraitFrame.lua:91
 GetTitleText = <function> defined @Interface/SharedXML/PortraitFrame.lua:28
 Inset = CustomTutorials1Inset {
 }
 SetPortraitTextureRaw = <function> defined @Interface/SharedXML/PortraitFrame.lua:79
 next = Button {
 }
 text = FontString {
 }
 TitleContainer = Frame {
 }
 SetTitleMaxLinesAndHeight = <function> defined @Interface/SharedXML/PortraitFrame.lua:49
 SetTitleColor = <function> defined @Interface/SharedXML/PortraitFrame.lua:32
 prev = Button {
 }
 shine = Frame {
 }
 DefaultPortraitTextureSizeAndOffset = <function> defined @Interface/SharedXML/PortraitFrame.lua:101
 SetTitle = <function> defined @Interface/SharedXML/PortraitFrame.lua:36
 SetBorder = <function> defined @Interface/SharedXML/PortraitFrame.lua:62
 layoutType = "PortraitFrameTemplate"
 flash = AnimationGroup {
 }
 SetPortraitToBag = <function> defined @Interface/SharedXML/PortraitFrame.lua:75
 PortraitContainer = Frame {
 }
 SetPortraitToUnit = <function> defined @Interface/SharedXML/PortraitFrame.lua:71
 Bg = CustomTutorials1Bg {
 }
 GetPortrait = <function> defined @Interface/SharedXML/PortraitFrame.lua:58
 SetTitleFormatted = <function> defined @Interface/SharedXML/PortraitFrame.lua:40
 NineSlice = Frame {
 }
 TopTileStreaks = Textur
olesean commented 1 year ago

I too, am experiencing this error.

WestComputing commented 1 year ago

Likewise

tyrrminal commented 1 year ago

I temporarily fixed this issue by commenting lines 36 and 154 of .../Addons/PetTracker/addons/config/tutorials.lua:

function Tutorials:Start()
    -- self:TriggerTutorial(4)
end
function Tutorials:TriggerOn(frame, ...)
    -- self:HookShown(frame, 'TriggerTutorial', ...)
end

The tutorial (and accompanying lua error) now never appear. Obviously this isn't a true solution, but it does mitigate the annoyance until a new version is released.

Katie-Fish commented 1 year ago

came here for this - will use tyrrminal's suggestion for now, too.

garbast commented 1 year ago

An alternative is, to comment line 55 in PetTracker/libs/CustomTutorials-2.1/CustomTutorials-2.1.lua

    frame:SetHeight((data.height or data.image and 220 or 100) + (data.text and frame.text:GetHeight() + (data.textY or 20) or 0))
    frame.TitleText:SetText(data.title or frame.data.title)
    frame.i = i

By this, you disable the TitleText:SetText call, which is the real error.