Jaliborc / PetTracker

Tracks pets, alerts for upgrades and helps you in pet battles.
49 stars 26 forks source link

Lua error in petbattle, frog bug ? #410

Open Hermonii opened 2 months ago

Hermonii commented 2 months ago

Which software were you running?

Have you read the changelog? Yes

Please describe the bug.

During a petbattle. Each turn the error pop up and the skills werent good like we can see on the screen.

Please describe how to reproduce it. Do a battle pet, but looks like isnt with all battles. Looks like the bug was with the skill from the frog "Croak". There wowhead link to the pet : https://www.wowhead.com/npc=222736/subterranean-dartswog

Any Screenshots? WoWScrnShot_090424_121037

Error Logs are Important! Message: .../PetTracker/addons/main/classes/abstract/ability.lua:17: Usage: GetAttackModifier(attackType, defenseType) Time: Wed Sep 4 12:11:14 2024 Count: 7 Stack: .../PetTracker/addons/main/classes/abstract/ability.lua:17: Usage: GetAttackModifier(attackType, defenseType) [string "@Interface/AddOns/PetTracker/addons/main/classes/abstract/ability.lua"]:17: in function GetModifier' [string "@Interface/AddOns/PetTracker/addons/main/classes/combat/abilityButton.lua"]:27: in functionDisplay' [string "@Interface/AddOns/PetTracker/addons/battle/enemyBar.lua"]:58: in function <...terface/AddOns/PetTracker/addons/battle/enemyBar.lua:53>

[string "@Interface/AddOns/Blizzard_SharedXMLBase/CallbackRegistry.lua"]:144: in function <...e/AddOns/Blizzard_SharedXMLBase/CallbackRegistry.lua:143>

[string "@Interface/AddOns/Blizzard_SharedXMLBase/CallbackRegistry.lua"]:147: in function `TriggerEvent' [string "@Interface/AddOns/Blizzard_SharedXMLBase/GlobalCallbackRegistry.lua"]:9: in function <...ns/Blizzard_SharedXMLBase/GlobalCallbackRegistry.lua:8>

Locals: self =

{ requisite = false id = 931 certain = true pet =
{ } cooldown = false } target =
{ index = 2 owner = 1 } = 931 = "Coassement" icon = 804966 = 0 = "Les chances de coup critique sont réduites de [abs(abilityStateMod(40,520))]%." _ = 1 type = nil healing = false

IntegraServe commented 2 months ago

I'm having the same issue for while battling wild pets. It doesn't happen with every pet grouping and unfortunately, I haven't noticed a pattern. FYI, here is my latest Lua error:

Message: .../PetTracker/addons/main/classes/abstract/ability.lua:17: Usage: GetAttackModifier(attackType, defenseType) Time: Thu Sep 5 00:00:40 2024 Count: 1 Stack: .../PetTracker/addons/main/classes/abstract/ability.lua:17: Usage: GetAttackModifier(attackType, defenseType) [string "@Interface/AddOns/PetTracker/addons/main/classes/abstract/ability.lua"]:17: in function GetModifier' [string "@Interface/AddOns/PetTracker/addons/main/classes/combat/abilityButton.lua"]:27: in functionDisplay' [string "@Interface/AddOns/PetTracker/addons/main/classes/combat/petSlot.lua"]:72: in function Display' [string "@Interface/AddOns/PetTracker/addons/battle/switcher.lua"]:78: in functionUpdateFor' [string "@Interface/AddOns/PetTracker/addons/battle/switcher.lua"]:69: in function Update' [string "@Interface/AddOns/PetTracker/addons/battle/switcher.lua"]:28: in functionPetBattlePetSelectionFrame_Show' [string "@Interface/AddOns/Blizzard_PetBattleUI/Blizzard_PetBattleUI.lua"]:197: in function `PetBattleFrame_PetSelectionFrameUpdateVisible'

Locals: self =

{ requisite = false id = 931 certain = true pet =
{ } cooldown = false } target =
{ index = 1 owner = 1 } = 931 = "Croak" icon = 804966 = 0 = "Your critical strike chance has been reduced by [abs(abilityStateMod(40,520))]%." _ = 1 type = nil healing = false

Hermonii commented 2 months ago

Found an other time this error and i can confirm that it's the "Croak" skill that trigger it.