Jaliborc / Scrap

Sells all your junk when you visit a merchant
34 stars 34 forks source link

Gear items with the same ilvl are partially sold. #264

Open Alezzzander opened 2 months ago

Alezzzander commented 2 months ago

Which software were you running?

Have you read the changelog? Mark if read. -Yes

Please describe the bug. Auto selling gear with low ilvl works partially. e.g. i have different types of gear of 270 ilvl,but only trinkets are sold automatically.All other gear(Plates,lealther,cloth,rings) aren't. Settings below.

Please describe how to reproduce it.

  1. Go to 'addon settings - junk list'
  2. Click on 'Low equipment and set 60% threahold'
  3. Go to raid Battle of Dazaldalor(Mythic), kill any boss,loot and open vendor.
  4. No lua errors here,but if you got trinket from some boss, it will automatically sold.

Any Screenshots? изображение

Error Logs are Important! Type /console scriptErrors 1 in the chat and reload the game. If an error window appears when reproducing the bug, please write here the first message (labelled 1/Many) that appeared. :warning: By default, the last error message is shown, not the first! You need to navigate back to the first error. I got just one lua error.when i checked Character specific option,but possibly its irrelevant here.

Message: Interface/AddOns/Scrap/addons/config/options.lua:56: attempt to call method 'SendSignal' (a nil value)
Time: Sun Sep  8 09:46:31 2024
Count: 1
Stack: Interface/AddOns/Scrap/addons/config/options.lua:56: attempt to call method 'SendSignal' (a nil value)
[string "@Interface/AddOns/Scrap/addons/config/options.lua"]:56: in function `method'
[string "@Interface/AddOns/Scrap/libs/Sushi-3.2/classes/core/Callable.lua"]:59: in function <...ddOns/Scrap/libs/Sushi-3.2/classes/core/Callable.lua:55>
[string "@Interface/AddOns/Scrap/libs/Sushi-3.2/Sushi-3.2.lua"]:28: in function `FireCalls'
[string "@Interface/AddOns/Scrap/libs/Sushi-3.2/classes/buttons/Clickable.lua"]:39: in function <...s/Scrap/libs/Sushi-3.2/classes/buttons/Clickable.lua:34>

Locals: share = CheckButton {
 calls = <table> {
 }
}
v = true
(*temporary) = nil
(*temporary) = Frame {
 subtitle = "These options allow you to configure your junk list and automatic junk detection further."
 title = "Junk List |A:poi-workorders:0:0:0:0|a"
 Footer = FontString {
 }
 limit = false
 Children = <table> {
 }
 calls = <table> {
 }
}
(*temporary) = "SETS_CHANGED"
(*temporary) = "attempt to call method 'SendSignal' (a nil value)"
self = Frame {
 subtitle = "These options allow you to configure your junk list and automatic junk detection further."
 title = "Junk List |A:poi-workorders:0:0:0:0|a"
 Footer = FontString {
 }
 limit = false
 Children = <table> {
 }
 calls = <table> {
 }
}
gizzmo commented 2 months ago

I too am experiencing this issue of Scrap not selling stuff that is clearly low level. Im wondering if its related to the "do not sell unknown transmog" feature that was recently added. I've noticed that a lot of the items are either unknown completely, or I don't have that specific item. But that doesn't make sense to not sell those as when you sell them, you learn the appearance anyways.