Jaliborc / Scrap

Sells all your junk when you visit a merchant
34 stars 34 forks source link

Warlords of Draenor Timewalking gear is considered scrap #57

Open BarbokOL opened 5 years ago

BarbokOL commented 5 years ago

Basically all in the title, it considers the warlords timewalking gear as scrap and tries to autosell it if the option to sell old gear is enabled, even when the item level is over 370

In my case the specific item is "Rivet-Sealed Shoulderplates (Timewarped Warforged) image

martijnhartlief commented 5 years ago

Yup even 415 timewalking gear is sold with the "old gear" option enabled. I did some more testing and not all items are vendored from time walking. But I could not find a reason why some items are vendored and some are not, for me rings and trinkets are vendored while armor was not. All I know for sure it's not based on the ilevel show in our interface since the 415 timewalking item was higher level than what I current have, so it's probably some internal value that is calculated differently.

When I look at the code what decides if an item is lowlevel I came across this part, and I was wondering what problem it solves:

local function GetValue(level, quality)
    if quality == LE_LE_ITEM_QUALITY_EPIC then
        return (level + 344.36) / 106.29
    elseif quality == LE_ITEM_QUALITY_RARE then
        return (level + 287.14) / 97.632
    else
        return (level + 292.23) / 101.18
    end
end

Perhaps the fact that these are blue timewalking items, their item level get's scaled weirdly?