Jaliborc / Sushi-3.2

A GUI framework, all wrapped in rice and seaweed for extra flavor.
27 stars 8 forks source link

Fix color picker for Classic addons #15

Closed verkkila closed 6 months ago

verkkila commented 9 months ago

The latest Bagnon update 10.2.18 broke the color picker functionality for some addons in Classic such as WeakAuras. This is a result of ColorPickerFrame.SetupColorPickerAndShow being assigned in the Sushi library as the presence of this function is used by other addons to determine the game version.

This PR proposes a fix for this issue that should work with both versions of the game (I've only tested the Classic version however).

Related issues: https://github.com/Jaliborc/Bagnon/issues/1874 https://github.com/Jaliborc/Bagnon/issues/1875

BernCarney commented 9 months ago

Tested in classic (Season of Discovery) and this does fix the colorpicker issue.

Jaliborc commented 6 months ago

Thank you for finding the cause. Fixed in latest commit.