search

Jalle19 / node-ffmpeg-mpegts-proxy

Simple proxy for leveraging ffmpeg to convert any source URL into MPEG-TS over HTTP
GNU General Public License v2.0
167 stars 52 forks source link

Feature request: Dockerfile #41

Closed reedog117 closed 6 years ago

reedog117 commented 6 years ago

Could you create a Dockerfile to launch a lightweight instance of this? (kinda similar to the arut/nginx-rtmp docker image in Docker Hub)

This would make things very easy for a one-step installation.

Jalle19 commented 6 years ago

@reedog117 can you try https://github.com/Jalle19/node-ffmpeg-mpegts-proxy/pull/45?

accessone67 commented 6 years ago

Just what I looked for. Thank you works great for me :)

Jalle19 commented 6 years ago

Cool. I'll push it to the Docker Hub at some point, I'll ping you here when it's done.

reedog117 commented 6 years ago

Just tried it and it works for me as well. One thing I did notice, though.. if I change the sources.json outside the container, the app doesn't notice the change and I have to restart the container. Not sure if this is a Docker limitation, though.

Jalle19 commented 6 years ago

Yeah I noticed the same thing, except it usually worked once, but not again after that. I'm not familiar enough with Docker to know whether it's a Docker thing or not unfortunately.

Jalle19 commented 6 years ago

Then again, if you have something in place that programmatically updates sources.json it probably isn't a too big of a deal to add a "docker restart" to it.

Jalle19 commented 6 years ago

I published the Docker image to Docker Hub: https://hub.docker.com/r/jalle19/node-ffmpeg-mpegts-proxy/. The README is updated to reflect that you don't have to build the container yourself anymore.