search

JamCoreModding / Notify

Unobtrusively notify users when mod updates are available.
MIT License
7 stars 1 forks source link

[BUG] SemVer Comparison is Broken #11

Closed Jamalam360 closed 2 years ago

Jamalam360 commented 2 years ago

Notify uses the FLoader version parsing and comparison API, but it is limited in that it can't parse versions like 1.1.3-rc1 or 1.5.4+1.17

A lot of mods use this kind of format, so it will be necessary to implement our own version parsing system to support as many mods as possible.

It should also use sensible defaults if the parsing fails.

Jamalam360 commented 2 years ago

After looking around, something like this could be used.

Jamalam360 commented 2 years ago

This was an issue with regex parsing. Now fixed with our new pattern