search

JamCoreModding / right-click-harvest

Right click crops to harvest them - with style.
MIT License
14 stars 11 forks source link

Incorrect Version mark on V4.4.0 #76

Closed God-Dnds closed 2 weeks ago

God-Dnds commented 2 weeks ago

On Curseforge the V4.4.0+1.21.1 Fabric (rightclickharvest-fabric-4.4.0+1.21.1.jar) is marked to work on 1.21.1 and 1.21 even though it does not work on 1.21 On 1.21 if the previous version is installed it works fine but curseforge prompts you to update. If you update Fabric will give an error saying the mod is for a different version.

Jamalam360 commented 2 weeks ago

Yeah, sorry that's a silly oversight on my part. I'll fix it soon.

God-Dnds commented 2 weeks ago

All good just wanted to make sure it was known!

God-Dnds commented 2 weeks ago

I see you pushed Harvest to 4.4.1 and Jamlib 1.2.2 but 1.21 is still crashing now with both giving an error.

Jamalam360 commented 2 weeks ago

Oh, the actual issue is that Fabric API is not updated for 1.21.

I would say either upgrade to 1.21.1 (there is no reason not to, it's just a hotfix to 1.21), or if you really want you can use dependency overrides to change the fabric api dependency on jamlib and rightclickharvest

God-Dnds commented 2 weeks ago

Ah I see, that makes sense. If fabric API doesn't end up having a 1.21+106 it may be smart to not mark updates as compatible (or not require above fabric 106 and use 102 for 1.21 since its the newest version for 1.21) so you don't get more reports in the future.

Also thank you for the knowledge that Dependency overrides are much easier that I expected (ofc something to using sparing and only if necessary)