search

Jamalmo / google-refine

Automatically exported from code.google.com/p/google-refine
Other
0 stars 0 forks source link

Undo History bug #2

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
On behalf of Thad Guidry: 

In testing Undo history with the attached TAR project file, I came across an 
error. 

Not sure if it is directly related to STARRED ROWS or not. My 
\history\1270136848043.change.zip file was there in Windows folder and still 
readable by 
Windows just fine, so not sure what problem Gridworks had with it in 
particular. I've attached 
both the project TAR file, and zipped the Windows folder itself for your 
review. 

ERROR OUTPUT : 

12:45:21.459 [ com.metaweb.gridworks] Using workspace directory: C:\Users\tgu 
idry\AppData\Local\Gridworks (0ms) 
12:45:21.461 [ com.metaweb.gridworks] Loading workspace from C:\Users\tguidry 
\AppData\Local\Gridworks\workspace.json (2ms) 
java.lang.RuntimeException: Failed to load change file 
C:\Users\tguidry\AppData\ 
Local\Gridworks\1809478922429.project\history\1270136848043.change.zip 
        at com.metaweb.gridworks.history.HistoryEntry.loadChange(HistoryEntry.ja 
va:144) 
        at com.metaweb.gridworks.history.HistoryEntry.revert(HistoryEntry.java:9 
9) 
        at com.metaweb.gridworks.history.History.undo(History.java:163) 
        at com.metaweb.gridworks.history.History.undoRedo(History.java:99) 
        at com.metaweb.gridworks.history.HistoryProcess.performImmediate(History 
Process.java:44) 
        at com.metaweb.gridworks.process.ProcessManager.queueProcess(ProcessMana 
ger.java:53) 
        at com.metaweb.gridworks.commands.edit.UndoRedoCommand.doPost(UndoRedoCo 
mmand.java:34) 
        at com.metaweb.gridworks.GridworksServlet.doPost(GridworksServlet.java:1 
58) 
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:727) 
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:820) 
        at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511 
) 
        at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:3 
90) 
        at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.jav 
a:216) 
        at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:1 
82) 
        at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:7 
65) 
        at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:418) 

        at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:1 
52) 
        at org.mortbay.jetty.Server.handle(Server.java:326) 
        at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:54 
2) 
        at org.mortbay.jetty.HttpConnection$RequestHandler.content(HttpConnectio 
n.java:938) 
        at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:755) 
        at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:218) 
        at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:404) 
        at org.mortbay.jetty.bio.SocketConnector$Connection.run(SocketConnector. 
java:228) 
        at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(Unknown Source 
) 
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source) 
        at java.lang.Thread.run(Unknown Source) 
Caused by: java.lang.reflect.InvocationTargetException 
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) 
        at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) 
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) 
        at java.lang.reflect.Method.invoke(Unknown Source) 
        at com.metaweb.gridworks.history.History.readOneChange(History.java:36) 
        at com.metaweb.gridworks.history.HistoryEntry.loadChange(HistoryEntry.ja 
va:157) 
        at com.metaweb.gridworks.history.HistoryEntry.loadChange(HistoryEntry.ja 
va:142) 
        ... 26 more 
Caused by: java.lang.ClassNotFoundException: newStarred=true 
        at java.net.URLClassLoader$1.run(Unknown Source) 
        at java.security.AccessController.doPrivileged(Native Method) 
        at java.net.URLClassLoader.findClass(Unknown Source) 
        at java.lang.ClassLoader.loadClass(Unknown Source) 
        at sun.misc.Launcher$AppClassLoader.loadClass(Unknown Source) 
        at java.lang.ClassLoader.loadClass(Unknown Source) 
        at java.lang.Class.forName0(Native Method) 
        at java.lang.Class.forName(Unknown Source) 
        at com.metaweb.gridworks.history.History.getChangeClass(History.java:51) 

        at com.metaweb.gridworks.history.History.readOneChange(History.java:32) 
        at com.metaweb.gridworks.model.changes.MassChange.load(MassChange.java:7 
2) 
        ... 33 more

Original issue reported on code.google.com by dfhu...@gmail.com on 9 May 2010 at 4:42

Attachments:

GoogleCodeExporter commented 8 years ago 
Fixed in r719. This bug could be observed by starring or flagging several rows 
and then undoing that operation. 
The undo would fail because the operation's change file could not be read back 
in.

Thad, could you please verify? Your existing file cannot be restored, but for 
future project files, you can star/flag 
rows and undo properly.

Original comment by dfhu...@gmail.com on 12 May 2010 at 6:37

GoogleCodeExporter commented 8 years ago

Original comment by dfhu...@gmail.com on 12 May 2010 at 6:37

GoogleCodeExporter commented 8 years ago 
Verified as fixed with 1 GB Aggregate load test and starring and flagging half 
of the 
rows from 826,000.  Undo and Redo worked correctly with flagged and starred 
rows being 
kept intact without errors.

Original comment by thadguidry on 13 May 2010 at 4:22

GoogleCodeExporter commented 8 years ago

Original comment by tfmorris on 18 Sep 2012 at 2:21

GoogleCodeExporter commented 8 years ago

Original comment by tfmorris on 18 Sep 2012 at 2:49