search

Jamalmo / google-refine

Automatically exported from code.google.com/p/google-refine
Other
0 stars 0 forks source link

Patch for 100% coverage of com.metaweb.gridworks.commands.util.CancelProcessesCommand #22

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Patch based on r724 which provides 100% coverage of 
com.metaweb.gridworks.commands.util.CancelProcessesCommand  (excluding 
inherited methods).

Original issue reported on code.google.com by iainsproat on 12 May 2010 at 11:45

GoogleCodeExporter commented 8 years ago 
Updated patch attached.  With further tests along the same line as before.

I've started adding guard statements to functions, throwing 
IllegalArgumentException if 
a parameter is null.

Also noticed that some of the code in Command.getEngine was a duplicate of 
Command.getEngineConfig, so I've refactored the former to call the latter.

Original comment by iainsproat on 12 May 2010 at 7:40

Attachments:

GoogleCodeExporter commented 8 years ago 
More tests (21 in total), and a bit more error catching and some slight 
refactoring.  
This supersedes the above patches.

Original comment by iainsproat on 12 May 2010 at 10:17

Attachments:

GoogleCodeExporter commented 8 years ago

Original comment by stefano.mazzocchi@gmail.com on 12 May 2010 at 11:55

GoogleCodeExporter commented 8 years ago 
Applied in r744. Looks good Iain, my suggestion is to just commit in the tree 
whatever new test you come up 
with, I'll watch over your shoulders from there (commit then review is a lot 
more effective than review than 
commit once we get things going)

Original comment by stefano.mazzocchi@gmail.com on 13 May 2010 at 12:55

GoogleCodeExporter commented 8 years ago

Original comment by iainsproat on 17 May 2010 at 12:04

GoogleCodeExporter commented 8 years ago

Original comment by tfmorris on 18 Sep 2012 at 2:21

GoogleCodeExporter commented 8 years ago

Original comment by tfmorris on 18 Sep 2012 at 2:54

GoogleCodeExporter commented 8 years ago

Original comment by tfmorris on 18 Sep 2012 at 2:56