search

Jamalmo / google-refine

Automatically exported from code.google.com/p/google-refine
Other
0 stars 0 forks source link

Don't coopt NotImplemented exceptions, particularly Sun internal ones #26

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
There are several places in the code where an Apache or Sun NotImplemented 
exception is thrown as some type of generic error.  If these things are never 
going to be implemented java.lang.UnsupportedOperation would be a better 
choice.  Using Sun internal classes is particularly problematic because a) 
they don't exist in all JVMs and b) they can go away at any time.  If some of 
the uses are stubs which will get implemented later, defining a Gridworks 
specific NotYetImplemented will allow you to easily identify this case.

The attached patch changes them all to java.lang.UnsupportedOperation.

Original issue reported on code.google.com by tfmorris on 13 May 2010 at 7:55

Attachments:

GoogleCodeExporter commented 8 years ago 
Yes, I also saw similar warnings in Netbeans regarding Sun proprietary stuff 
and warned 
that they could go away at any time.  If I recall, a bunch of "Signal" stuff.

Original comment by thadguidry on 13 May 2010 at 8:30

GoogleCodeExporter commented 8 years ago 
applied at r756

Original comment by stefano.mazzocchi@gmail.com on 13 May 2010 at 9:03

GoogleCodeExporter commented 8 years ago

Original comment by tfmorris on 18 Sep 2012 at 2:21

GoogleCodeExporter commented 8 years ago

Original comment by tfmorris on 18 Sep 2012 at 2:56