search

JameH2 / Hbm-s-Nuclear-Tech-GIT

A blazing wreck of a minecraft mod about nuclear technology that is somehow still in development. (for meme use)
GNU General Public License v3.0
73 stars 20 forks source link

NTM space overwrites the botania's garden of glass sky in the overworld with no way to disable it #123

Open brandyyn opened 3 months ago

brandyyn commented 3 months ago

NTM space overwrites the botania's garden of glass sky in the overworld with no way to disable it

i have this set to false: image

brandyyn commented 3 months ago

FIX IT PLEASEEE image

SuperTechxter commented 3 months ago

space is cooler deal with it 😎

brandyyn commented 3 months ago

space is cooler deal with it 😎

its literally the default mc skybox with a glitchy satellite jumping around and disappearing and reappearing constantly. i prefer botania :3

MellowArpeggiation commented 3 months ago

I've noticed issues with satellite jerkiness in multiplayer (fix incoming), but not in singleplayer, are you in singleplayer? Also the skybox merely mimics the default MC skybox, if you change the atmospheric composition it'll change dramatically. Since we effectively reimplement the entire skybox, the chainloader can't work. The config option remaining is an oversight however, so I'll fix that up.

brandyyn commented 3 months ago

I've noticed issues with satellite jerkiness in multiplayer (fix incoming), but not in singleplayer, are you in singleplayer? Also the skybox merely mimics the default MC skybox, if you change the atmospheric composition it'll change dramatically. Since we effectively reimplement the entire skybox, the chainloader can't work. The config option remaining is an oversight however, so I'll fix that up.

yeah, i'm in singleplayer.

I don't like the satellite in my skybox regardless, nor do I like the default MC skybox- the config should remain. You can still do all your fancy sky box things on other planets because the Botania Skybox only affects the overworld, and furthermore I believe this will also break optifine's custom sky and notfine/mcpf's custom sky?

MellowArpeggiation commented 3 months ago

Again, not an option, if you change the atmospheric composition of the Earth, but the skybox remains a cool blue, you'll suffocate with no indication as to why. We could add configs to the satellite visibility but I'd rather fix the jerkiness beforehand. How much we can improve skybox compat will depend on how other mods have implemented theirs, so I'll investigate.

brandyyn commented 3 months ago

Again, not an option, if you change the atmospheric composition of the Earth, but the skybox remains a cool blue, you'll suffocate with no indication as to why. We could add configs to the satellite visibility but I'd rather fix the jerkiness beforehand. How much we can improve skybox compat will depend on how other mods have implemented theirs, so I'll investigate.

Well if you can implement a cooler looking skybox than normal MC, that would be cool too. I just don't want to lose a cool skybox over practically nothing in my case.

Can you even change the atmospheric composition of Earth in survival?

MellowArpeggiation commented 3 months ago

Yes, as demonstrated in another issue (#125), terraforming is already possible, with more machines planned to make the process even more accessible, depending on your tech level.

brandyyn commented 3 months ago

Yes, as demonstrated in another issue (#125), terraforming is already possible, with more machines planned to make the process even more accessible, depending on your tech level.

lovely. I pray for a cool skybox of Earth in the future. Please :)

brandyyn commented 3 months ago

Again, not an option, if you change the atmospheric composition of the Earth, but the skybox remains a cool blue, you'll suffocate with no indication as to why. We could add configs to the satellite visibility but I'd rather fix the jerkiness beforehand. How much we can improve skybox compat will depend on how other mods have implemented theirs, so I'll investigate.

@MellowArpeggiation

https://streamable.com/3hgf9v

https://streamable.com/uqyqza

MellowArpeggiation commented 2 months ago

Thanks for the demonstration, I'm assuming that's on the latest version (x5074)?

brandyyn commented 2 months ago

Thanks for the demonstration, I'm assuming that's on the latest version (x5074)?

Yes. I also just don't like the satellite at all and would prefer to just disable it. It's ugly and distracting and way too fast

MellowArpeggiation commented 2 months ago

Thanks for the input, I wouldn't hold your breath on their removal though.

brandyyn commented 2 months ago

Thanks for the input, I wouldn't hold your breath on their removal though.

Literally just a config option…

MellowArpeggiation commented 2 months ago

I am becoming less inclined to help you the more you bellyache about a moving dot. I have slowed down the satellites a touch and implemented an entirely new timing system that uses your system time rather than the in-game ticks+partials which introduces judder on fast objects. It should now be perfectly smooth regardless of network conditions, mod interactions, and anything else, this will be end of this matter.

I'm leaving this issue open to remind myself to work on skybox compat, I will consider more configuration options in the future.