search

Jamee999 / cricket

Test match cricket simulator
61 stars 33 forks source link

Not all games work in recreate mode #10

Open Jamee999 opened 6 years ago

Jamee999 commented 6 years ago

The following games do not work in recreate mode:

71, 123, 156, 163, 190, 211, 284, 418, 586, 650, 696, 705, 831, 845, 879, 920, 922, 948, 981, 1053, 1076, 1094, 1179, 1189, 1226, 1242, 1309, 1310, 1312, 1374, 1387, 1396, 1426, 1483, 1502, 1524, 1565, 1571, 1768, 1781, 1793, 1825, 1907, 1909, 1911, 1982, 2012, 2030, 2034, 2083, 2143, 2145, 2153, 2174, 2197, 2218, 2224, 2226, 2229, 2242

It currently is known not to work if both teams don't have all 11 men bat in the first innings, but also in some other conditions. Some of them will be fixable with better code, but I might have to come up with different solutions for games that were abandoned very quickly. If a team doesn't bat at all, cricinfo scorecards don't seem to even list the lineup.

There are also some cases where the name cricinfo uses on the scorecard for a player is different than his name on the page where I scraped the player info from. I am currently handling those issues manually.

If I can get the failures down to a smaller number, it might be possible to just hardcode in the lineups.

Jamee999 commented 4 years ago

Recreate was not included in v2.0. I would like to reincorporate it, though.