search

James-Thorson-NOAA / FishLife

Estimate fish traits for all marine fish species globally
https://james-thorson-noaa.github.io/FishLife/
GNU General Public License v3.0
45 stars 12 forks source link

Update Search_species.R for new rfishbase version #21

Closed DanOvando closed 10 months ago

DanOvando commented 1 year ago

Been running into a few issues maintaining the older version of rfishbase that had the taxa table built in. This solution works on my end with the newer versions of rfishbase (Currently running 4.0.0). This version loads the taxa table once the first time it is called and prints out some annoying text, but caches the resulting taxa table for future calls within a session. One downside is that means an internet connection is required. Thoughts? Would need to update DESCRIPTION file as well to something like rfishbase (>= 4.0.0) or whenever that change was made

James-Thorson commented 10 months ago

Sorry, just doing end-of-year housekeeping and seeing this now. Instead, I require the user to download the old version of rfishbase and DESCRIPTION reflects that requirement.

Closing for now but happy to follow up