fix: Years2Include was not being passed to PlotMap_Fn

James-Thorson-NOAA / FishStatsUtils

Shared resources for spatio-temporal models

GNU General Public License v3.0

10 stars 16 forks source link

fix: Years2Include was not being passed to PlotMap_Fn #11

Closed kellijohnson-NOAA closed 5 years ago

kellijohnson-NOAA commented 5 years ago

This could be done in a potentially different way as I am not that familiar with the code base of FishStatsUtils. Nevertheless, there is a need to create residual plots only for the years in which there is empirical data to inform them. It doesn't appear that Years2Include is doing anything in the plot_residuals currently. The fix includes two subsets,

one on Mat (the columns) and
- one on labels for each year via Year_Set

The fix worked for VASTWestCoast

James-Thorson-NOAA commented 5 years ago

Hi there,

This is a lot more small changes than seems necessary for the listed issue. Please email me directly or submit a smaller pull request?

kellijohnson-NOAA commented 5 years ago

Commits in this fork are specific to stuff needed for VASTWestCoast. I am closing the pull request until the commits are better tested given that they have now grown larger than wanting to subset some years.