James-Thorson-NOAA / FishStatsUtils

Shared resources for spatio-temporal models
GNU General Public License v3.0
10 stars 16 forks source link

fix(Prepare_XXXX_Extrapolation_Data_Fn): Depth was mislabeled #51

Closed kellijohnson-NOAA closed 4 years ago

kellijohnson-NOAA commented 4 years ago

Depth column should be BEST_DEPTH_M to work with match_strata_fn(). Using cbind resulted in the column being labeled Depth as it was extracted. Now, using data.frame the column is named with the correct label.

James-Thorson-NOAA commented 4 years ago

Thanks for raising this topic -- I'm not confident that all extrapolation-grids will play well with match_strata_fn, which was originally designed just for the NWFSC usage. I'll start an email thread to work out how to proceed.

James-Thorson-NOAA commented 4 years ago

OK, we've discussed and I'll add this edit to the development branch, and close the issue here to avoid duplication.