James-Thorson-NOAA / FishStatsUtils

Shared resources for spatio-temporal models
GNU General Public License v3.0
10 stars 16 forks source link

... in `plot_results` leads to warning with `Dens_xt = do.call(what = plot_maps, args = plot_maps_args)` #53

Open kellijohnson-NOAA opened 4 years ago

kellijohnson-NOAA commented 4 years ago

https://github.com/James-Thorson-NOAA/FishStatsUtils/blob/82cd3b5e07baa92d182c0746558575e0be597e52/R/plot_results.R#L118

I get the logic here of wanting to pass information but it is passing everything, even information intended for other plots. For example, I wanted to pass strata_names to plot_biomass_indexand it also tries to pass it topar(Par)inplot_maps` where I get the following error

In par(Par) : "strata_names" is not a graphical parameter

I can work around this by making a direct call to plot_biomass_index(strata_names = ) but I thought it was worth bringing the topic up in case others are wanting to pass non-standard information through plot_results(). Feel free to close this issue if you feel users should be calling plots individually.