James-Thorson-NOAA / FishStatsUtils

Shared resources for spatio-temporal models
GNU General Public License v3.0
10 stars 16 forks source link

Dependency installation: plotKML removed from CRAN #76

Closed Jason-Conner-NOAA closed 3 years ago

Jason-Conner-NOAA commented 3 years ago

Just a note that the package plotKML has been removed from CRAN and is unavailable for default installation of FishStatsUtils. https://cran-archive.r-project.org/web/checks/2021/2021-10-06_check_results_plotKML.html

James-Thorson-NOAA commented 3 years ago

A quick googling suggests that raster::rasterize might do the same thing as plotKML::vect2rast as used in FishStatsUtils::plot_variable. Does anyone have time to explore a bit?

James-Thorson-NOAA commented 3 years ago

I just spent a quick moment implementing this fix on the dev branch. I'm closing the issue but happy to hear feedback on implementation here.

James-Thorson commented 3 years ago

As a note to myself ... It looks like sp::SpatialPixelsDataFrame could be an alternative to raster::rasterize ... Could be investigated in the future if dependency issues continue

On Sat, Oct 16, 2021, 10:40 AM Jim Thorson @.***> wrote:

Closed #76 https://github.com/James-Thorson-NOAA/FishStatsUtils/issues/76.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/James-Thorson-NOAA/FishStatsUtils/issues/76#event-5473319019, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB46UTO5WUY4GBVXELJ6IP3UHG2HJANCNFSM5FRYUMTQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.