search

James-Thorson-NOAA / VAST

Spatio-temporal analysis of univariate or multivariate data, e.g., standardizing data for multiple species or stages
http://www.FishStats.org
GNU General Public License v3.0
124 stars 53 forks source link

make_spatial_info and make_kmeans functions return error for stream network model with RANN version 2.6.2 #394

Open ACharsley opened 1 week ago

ACharsley commented 1 week ago

Hi,

I recently ran a stream network model with the version 2.6.2 of the RANN package (the most recent CRAN version). I got the following error when using the make_spatial_info / make_kmeans functions:

Error in .C("get_NN_2Set", as.double(data), as.double(query), as.integer(dimension)

However, when I changed back to RANN version 2.6.1, I didn't get this error. This also wasn't an issue when using knot_method = "grid". I don't have time to explore this issue further, but I thought I would flag this issue in case anyone runs into this problem.

James-Thorson-NOAA commented 1 week ago

OK, thanks for flagging it! I'll keep track of requests here to determine priority for maintenance.

And FWIW, tinyVAST eliminates the RANN dependency for stream-network models, and I think @jeremyharris7 is finding it to be pretty easy to bridge over, in case that's of interest