James-Yu / LaTeX-Workshop

Boost LaTeX typesetting efficiency with preview, compile, autocomplete, colorize, and more.
MIT License
10.76k stars 535 forks source link

White borders (margin, gap, space) occur on the bottom and the right side of pages in the internal PDF viewer when dark background is enabled #4431

Closed ghake closed 1 month ago

ghake commented 1 month ago

Pre-checks*

Please change the following [ ] to [x] for confirmation.

  • [x] The issue has not been reported in this repository.
  • [x] The issue remains after disabling all other extensions and restarting Visual Studio Code.
  • [x] The FAQ cannot address the issue.
  • [x] The issue is not related to compiling a document, or the document can be successfully compiled in the OS terminal but not in Visual Studio Code with this extension.

Environment*

Please write exact version numbers instead of descriptors such as latest.

  • Operating System: MacOs
  • Visual Studio Code Version: 1.94.2
  • LaTeX Workshop Version: v10.5.0

The Issue*

Please briefly describe the issue you come across.

"latex-workshop.view.pdf.color.dark.pageColorsBackground": "#253237",
"latex-workshop.view.pdf.color.dark.pageColorsForeground": "lightgrey",
"latex-workshop.view.pdf.color.dark.backgroundColor": "#253237",
"latex-workshop.view.pdf.color.dark.pageBorderColor": "#253237",

It is supposed to look like this:

grafik

But instead white borders (margin,gap,space) occur on the bottom and the right side of the pages and it looks like this :

Bildschirmfoto 2024-10-12 um 09 08 17

I guess it's this pdf.js bug .

James-Yu commented 1 month ago

Yes, that's an upstream issue. Will update to latest.