JamesAC42 / shovel

productivity tool for going deep in your work
https://ovel.sh
Other
35 stars 4 forks source link

Usernames should be case insensitive #10

Closed 4rnv closed 1 month ago

4rnv commented 5 months ago

Hello, it's me again, I really like the updated interface, especially on mobile.

Steps to recreate issue

Screenshot 2024-05-12 at 22-10-07 shovel

Screenshot 2024-05-12 at 22-10-52 shovel

On most platforms usernames are case insensitive and the login is successful irrespective of whether the input is in CAPS or not. Right now it would be possible to create several accounts with the same username by using different variations of casing. Not sure if that is ideal.

enisaras commented 5 months ago

In my personal opinion usernames should always be emails to avoid this issue. Maybe we can have the user login with their email and treat display name separately.

4rnv commented 5 months ago

In my personal opinion usernames should always be emails to avoid this issue. Maybe we can have the user login with their email and treat display name separately.

Using email addresses would also help deal with forgotten passwords.

Alternately, usernames could be converted to lowercase before being stored, and during login the user input would also be converted to lowercase before comparison. Either approach would work IMO.

JamesAC42 commented 5 months ago

Noted, will add (optional) email support and handle case-sensitivity better.