JamesBarwell / rpi-gpio.js

Control Raspberry Pi GPIO pins with node.js
MIT License
657 stars 116 forks source link

Update dependencies and fix tests #84

Closed aslafy-z closed 5 years ago

aslafy-z commented 6 years ago

Updated dependencies:

I'd like some help to fix the two last failing tests, please !

JamesBarwell commented 6 years ago

I've been aware that some of the dependencies are very out of date, but haven't wanted to jump into bumping them yet until I understand what the consequences are for older versions of node.

At the moment this module supports node down to version 0.10.0. It's a very old version and not one that I would ordinarily support, but it still seems to be the default one installed with Raspbian. My concern is that if we drop support then it's going to cause a lot issues for users who are newer to node / Linux.

My understanding is that, for example, epoll 2.x only supports node 4.x, so I can't take this without breaking the current support.

My plan was to get to a stable 1.x version and make that the final one with 0.10.x support, then bump to a 2.x line with the upgrades. It looks like node 10.x has come out, broken stuff and made this a bit more of a priority. I'll look to get this merged onto a branch shortly so that people can start testing with node 10.x. Cheers.

JamesBarwell commented 6 years ago

I've published a v1.0.0 build of the module as it stood, in order to make way for merging this in. I've pulled this into a v2 branch and got the tests passing.

I've had to throw away the code prettification I'm afraid, as it's not backwards compatible with node 4. The code is in need of a tidy up and maybe a more formalised approach to linting but I'll look at that separately. Don't really want to change too much all in one go.

The branch for v2 is pushed so feel free to have a go if you have time. I want to do some more testing myself before publishing and I'll leave this PR open until I'm happy with it.

Cheers.

JamesBarwell commented 5 years ago

This is in master and published now, and it included your work from this PR. Cheers.