Does not fail gracefully on Safari

JamesBrill / react-speech-recognition

💬Speech recognition for your React app

https://webspeechrecognition.com/

MIT License

674 stars 120 forks source link

Does not fail gracefully on Safari #16

Closed ish-joshi closed 5 years ago

ish-joshi commented 5 years ago

The graceful exit does not work on safari as it's trying to do computation with 'recognition' variable when it's null. Safari is not a supported browser.

Hence, a possible fix is adding the if statement (commented out below)

I've also added a pull request https://github.com/FoundersFactory/react-speech-recognition/pull/17

JamesBrill commented 5 years ago

Thanks for raising this! I've merged your PR and will publish a new version immediately.

JamesBrill commented 5 years ago

Fixed in version 2.0.1

Thanks for your contribution!