search

JamesBroadberry / deno-bcrypt

A port of jBCrypt to TypeScript for use as a Deno module
ISC License
67 stars 5 forks source link

Version Std Encoding Import #5

Closed ebebbington closed 4 years ago

ebebbington commented 4 years ago

It would be nice if you could version the following import on bcrypt/bcrypt.ts:

import { encode } from "https://deno.land/std/encoding/utf8.ts";

To avoid using the master branch and causing any issues for users (should any ever arise)

JamesBroadberry commented 4 years ago

Yeah, that's a good idea - I'll add it in. Thanks for the suggestion!

ebebbington commented 4 years ago

Nice one! While i'm here, really nice work on bcrypt! So glad Deno has this :)

JamesBroadberry commented 4 years ago

I've updated the code to reference specific versions of the std modules, let me know if you think there are any issues still 👍

No problem 😄 I wanted something useful to do using Deno and used bcrypt before in a Node.js project so thought it'd be worth porting over. Glad to hear you're finding it useful!

ebebbington commented 4 years ago

Bloody hell that was fast! And I was so happy some ported over bcrypt :P Keep up the great work!