JamesCoyle / DownloadsExtension

A replacement for the default Chrome downloads shelf
Other
18 stars 2 forks source link

[Bug] Chrome Freeze/Crash upon Download #15

Open Nes370 opened 2 years ago

Nes370 commented 2 years ago

Hello, I've been using your extension for some months now and just earlier this week I was experiencing an issue where whenever I would download any file through Google Chrome, it would begin downloading the item and then immediately freeze up. Checking my downloads folder, the item was successfully downloaded, however Chrome would become inoperable. I would then be forced to close Chrome through Task Manager, and restart the application before I could resume web browsing.

I tried restarting Chrome multiple times, restarting my computer, and yet each time I would open Chrome and download my first item, it would freeze again. Eventually the problem went away when I disabled the Downloads extension. So I believe that something unexpected occurred in the Downloads extension that was the cause of my problems.

I'm sorry that I cannot pinpoint anything more specific than these symptoms and not a specific cause as now I've resolved the issue for myself by disabling the extension for a few days, and turning it back on now and the problem is no longer present. However, I thought it would be good to make you aware of the potential issue.

Nes370 commented 2 years ago

Scratch that, the problem is still persistent. I have to disable the extension to avoid crashes still.

D3SK3R commented 2 years ago

Same here, also, I started noticing that the icon was blue, whenever I opened the browser (should be white, as I left it) and, when this happens, if I click the extension, chrome completely freezes for like, 20 seconds, then it shows the downloads and the icon goes back to white, I 'fixed' it by clearing all my downloads.

JamesCoyle commented 2 years ago

Thanks for reporting this. I'll look into it ASAP.

JamesCoyle commented 2 years ago

To help me narrow it down:

Nes370 commented 2 years ago
Nes370 commented 2 years ago

image image image

Nes370 commented 2 years ago

To further clarify, there seems to be 2 states of operation:

It briefly switched to the former for me, and that is how I was able to screenshot that information, but now it is back to the latter state. I'm not sure what is causing the switch in operability.

JamesCoyle commented 2 years ago

Would it be possible for you to go to chrome://downloads and clear all the downloads from the three dots menu in the upper right?

I can't seem to replicate the issue at the moment so it's not easy to debug this issue. If it is caused by the number of downloads you have then clearing your download history should hopefully stop the crashing issue. If that is the case it gives me somewhere to start looking and I can implement some improvements to prevent the crash in future.

The 0/4 badge in red is intended behavior due to the 4 errored downloads you have. Those downloads are considered in progress but halted due to the error. Clearing those downloads should remove the badge.

Nes370 commented 2 years ago

Okay, I have cleared my downloads from chrome://downloads and the issue is still present. Attempting to download an image causes a crash, and clicking on the download shelf causes a crash.

Nes370 commented 2 years ago

Okay, now I'm also having a new issue. When I go back to chrome://downloads, it's showing the items that should have been cleared earlier, and Chrome immediately starts to build up RAM usage and then eventually crashes from viewing the downloads page.

Nes370 commented 2 years ago

Disabling the Download Manager allows me to safely view the downloads page without crashing. I cleared the downloads again while the extension was disabled, and then re-enabled the extension. I am now able to download images and view the downloads shelf without issue.

JamesCoyle commented 2 years ago

Right so it sounds like you had enough downloads that the stored states exceeded the local storage limit for extensions. It clears that storage on install so makes sense disabling it and enabling it again would sort that issue.

I do have one idea to reduce memory usage which will also help me fix another issue so I'll look to get that implemented when I have some free time and we can see if that fixes the issue properly.

JamesCoyle commented 2 years ago

I've not had chance to implement the changes required for this yet but I'm also going to look at changing how I check for download progress so I only fetch the data for downloads that are in progress rather than all of them at once.

Thank you for being patient. I'll hopefully be able to find some free time to work on this at some point soon.