search

JamesEggers1 / luhn

A JavaScript module of the luhn algorithm for Credit Card Validation that works with both client-side JavaScript and Node.js
MIT License
52 stars 17 forks source link

Version 2.0 provides "can't find variable: module" error #9

Closed tomaszlabacki closed 6 years ago

tomaszlabacki commented 9 years ago

Hi guys, after upgrade to 2.0 we have ReferenceError: Can't find variable: module problem during karma testing phase.

Some logs:

INFO [karma]: Karma v0.12.37 server started at http://localhost:9876/
INFO [launcher]: Starting browser PhantomJS
INFO [PhantomJS 1.9.8 (Linux 0.0.0)]: Connected on socket Ffl1DeLaMFIXy6QgbOeu with id 66221296
PhantomJS 1.9.8 (Linux 0.0.0) ERROR
  ReferenceError: Can't find variable: module
  at /tmp/app/target/main/6a26ec8/js/lib.js:1255

We solved this by using version "c521434489d38fe561667f26ca2616c8e7e430a3" (unfortunately there is no tags in repo) in our bower.json, but it would be nice to have the lastest one ;)

JamesEggers1 commented 6 years ago

This was an issue associated with a bug in the minified version. This has been corrected in version 2.2 and later.