search

JamesGlanville / GF2

0 stars 0 forks source link

Wrong line numbers in error print out #12

Open ghost opened 11 years ago

ghost commented 11 years ago

If you run test5 (using parser_test) then errors are reported to be on the wrong line.

JamesGlanville commented 11 years ago

I can't see test5, have you added it to git?

ghost commented 11 years ago

Yeah it says commit happened 6 minutes go

On 29 May 2013 17:30, James Glanville notifications@github.com wrote:

I can't see test5, have you added it to git?

— Reply to this email directly or view it on GitHubhttps://github.com/JamesGlanville/GF2/issues/12#issuecomment-18629000 .

JamesGlanville commented 11 years ago

I can't find it, are you sure it's not untracked? (git status to find out, git add to add)

On 29 May 2013 17:34, GeorgeAyris notifications@github.com wrote:

Yeah it says commit happened 6 minutes go

On 29 May 2013 17:30, James Glanville notifications@github.com wrote:

I can't see test5, have you added it to git?

— Reply to this email directly or view it on GitHub< https://github.com/JamesGlanville/GF2/issues/12#issuecomment-18629000> .

— Reply to this email directly or view it on GitHubhttps://github.com/JamesGlanville/GF2/issues/12#issuecomment-18629223 .

ghost commented 11 years ago

My bad, sorted

On 29 May 2013 17:36, James Glanville notifications@github.com wrote:

I can't find it, are you sure it's not untracked? (git status to find out, git add to add)

On 29 May 2013 17:34, GeorgeAyris notifications@github.com wrote:

Yeah it says commit happened 6 minutes go

On 29 May 2013 17:30, James Glanville notifications@github.com wrote:

I can't see test5, have you added it to git?

— Reply to this email directly or view it on GitHub< https://github.com/JamesGlanville/GF2/issues/12#issuecomment-18629000> .

— Reply to this email directly or view it on GitHub< https://github.com/JamesGlanville/GF2/issues/12#issuecomment-18629223> .

— Reply to this email directly or view it on GitHubhttps://github.com/JamesGlanville/GF2/issues/12#issuecomment-18629354 .

JamesGlanville commented 11 years ago

I'll try and fix this tonight, but the problem is that printerror isn't liking multiple semi-colons per line, or semi-colons at the beginning of a line. How important is it to get this exactly right? I'm anxious not to break anything, and getting this to work would be a major rewrite.

ghost commented 11 years ago

Personal choice on whether you think it's worth it for correct line numbers? Is there any possibility of a correction where you subtract from the line number based on semicolons and carriage returns?

On 29 May 2013 17:44, James Glanville notifications@github.com wrote:

I'll try and fix this tonight, but the problem is that printerror isn't liking multiple semi-colons per line, or semi-colons at the beginning of a line. How important is it to get this exactly right? I'm anxious not to break anything, and getting this to work would be a major rewrite.

— Reply to this email directly or view it on GitHubhttps://github.com/JamesGlanville/GF2/issues/12#issuecomment-18629886 .