search

JamesGlanville / GF2

0 stars 0 forks source link

Moncount #15

Closed AndyHolt closed 11 years ago

AndyHolt commented 11 years ago

Any ideas why the moncount function would have stopped working since yesterday?

I was getting the monitors loaded into the combobox correctly, but now mmz->moncount() returns 0 for both config files in the src directory, so no monitors are being loaded.

JamesGlanville commented 11 years ago

I have no idea i'm afraid. git bisect is a very useful tool to find out what broke (it helps you do a binary search through the history to find out what commit broke it)

On 29 May 2013 23:37, adh635 notifications@github.com wrote:

Any ideas why the moncount function would have stopped working since yesterday?

I was getting the monitors loaded into the combobox correctly, but now mmz->moncount() returns 0 for both config files in the src directory, so no monitors are being loaded.

— Reply to this email directly or view it on GitHubhttps://github.com/JamesGlanville/GF2/issues/15 .

AndyHolt commented 11 years ago

woah, git bisect is pretty cool. I had no idea this was a thing. I'll give it a try...

AndyHolt commented 11 years ago

Found the problem (probably causing some of the other bugs I've been struggling with tonight too).

In commit d63d194bf98f50cf8222be776de23b5e36434e80 started on VERY UGLY terminal like code, the gui constructor was moved from AFTER the parser runs to BEFORE.

This means the errors can be outputted nicely, but also means that no initialisation has happened when the GUI is created.

I think the best solution is to leave it as it is now and I'll have to do quite a bit of work to get the gui working properly by setting it up properly after the file is parsed, but it should be do-able. At least I have an excuse if it doesn't work by Friday.

Going to bed now, but I'll get cracking on this in the morning. Let me know ASAP if you have any other ideas how to fix it.

JamesGlanville commented 11 years ago

oh I'm really sorry about that, I hadn't found any bugs from that and it printed more to the terminal display. Let me know how I can help when you decide what the best plan of action is.

On 30 May 2013 01:06, adh635 notifications@github.com wrote:

Found the problem (probably causing some of the other bugs I've been struggling with tonight too).

In commit d63d194https://github.com/JamesGlanville/GF2/commit/d63d194bf98f50cf8222be776de23b5e36434e80started on VERY UGLY terminal like code, the gui constructor was moved from AFTER the parser runs to BEFORE.

This means the errors can be outputted nicely, but also means that no initialisation has happened when the GUI is created.

I think the best solution is to leave it as it is now and I'll have to do quite a bit of work to get the gui working properly by setting it up properly after the file is parsed, but it should be do-able. At least I have an excuse if it doesn't work by Friday.

Going to bed now, but I'll get cracking on this in the morning. Let me know ASAP if you have any other ideas how to fix it.

— Reply to this email directly or view it on GitHubhttps://github.com/JamesGlanville/GF2/issues/15#issuecomment-18654139 .

AndyHolt commented 11 years ago

The first thing to be done is putting the initialisation of the switches list and monitors lists in a separate function and calling it after the parser is done. Its mostly copying and pasting code from the current constructor. IF you want to do something tonight, you could implement that and check the behaviour for the GUI dialog boxes works the same as it did last night. Don't worry if you don't want to though, I should be able to sort it fairly quickly tomorrow.

As an aside, I think I'll have to spend all day coding this tomorrow, probably won't do datalogger if that's ok with you (obviously I'll sit in the eietl as I do so between 11-1).

JamesGlanville commented 11 years ago

I'm going to bed very soon so I won't now, feel free to focus on software tomorrow, I think I should be able to finish the datalogger tomorrow on my own if you're there to help out occasionally with wxwidgets stuff.

On 30 May 2013 01:15, adh635 notifications@github.com wrote:

The first thing to be done is putting the initialisation of the switches list and monitors lists in a separate function and calling it after the parser is done. Its mostly copying and pasting code from the current constructor. IF you want to do something tonight, you could implement that and check the behaviour for the GUI dialog boxes works the same as it did last night. Don't worry if you don't want to though, I should be able to sort it fairly quickly tomorrow.

As an aside, I think I'll have to spend all day coding this tomorrow, probably won't do datalogger if that's ok with you (obviously I'll sit in the eietl as I do so between 11-1).

— Reply to this email directly or view it on GitHubhttps://github.com/JamesGlanville/GF2/issues/15#issuecomment-18654390 .

AndyHolt commented 11 years ago

Sure, happy to be in the department all day (I'll probably have more to ask you than you will me).