search

JamesGlanville / GF2

0 stars 0 forks source link

Setting switches #19

Closed ghost closed 11 years ago

ghost commented 11 years ago

Say if you have just set switch a to high and want to set switch b to high then you have to select switch b then select low and then select high.

Propose if you select a different switch it alters the value then (more preferable, but harder would be to for the high/low drop down to default to the current value of the switch).

Hope this makes sense.

JamesGlanville commented 11 years ago

I had a look at doing this and thought it was tricky, do we have time?

On 31 May 2013 02:18, GeorgeAyris notifications@github.com wrote:

Say if you have just set switch a to high and want to set switch b to high then you have to select switch b then select low and then select high.

Propose if you select a different switch it alters the value then (more preferable, but harder would be to for the high/low drop down to default to the current value of the switch).

Hope this makes sense.

— Reply to this email directly or view it on GitHubhttps://github.com/JamesGlanville/GF2/issues/19 .

ghost commented 11 years ago

Modified gui.cc so that when you select a different switch it changes the value of the switch to what is currently in the switch high/low drop down

JamesGlanville commented 11 years ago

Definitely good if possible though.

On 31 May 2013 02:25, James Glanville james.n.glanville@gmail.com wrote:

I had a look at doing this and thought it was tricky, do we have time?

On 31 May 2013 02:18, GeorgeAyris notifications@github.com wrote:

Say if you have just set switch a to high and want to set switch b to high then you have to select switch b then select low and then select high.

Propose if you select a different switch it alters the value then (more preferable, but harder would be to for the high/low drop down to default to the current value of the switch).

Hope this makes sense.

— Reply to this email directly or view it on GitHubhttps://github.com/JamesGlanville/GF2/issues/19 .

ghost commented 11 years ago

Better would possibly be a button that sets the value, but this works being short on time

ghost commented 11 years ago

Do you mind just checking what I've done works?

On 31 May 2013 02:25, James Glanville notifications@github.com wrote:

Definitely good if possible though.

On 31 May 2013 02:25, James Glanville james.n.glanville@gmail.com wrote:

I had a look at doing this and thought it was tricky, do we have time?

On 31 May 2013 02:18, GeorgeAyris notifications@github.com wrote:

Say if you have just set switch a to high and want to set switch b to high then you have to select switch b then select low and then select high.

Propose if you select a different switch it alters the value then (more preferable, but harder would be to for the high/low drop down to default to the current value of the switch).

Hope this makes sense.

— Reply to this email directly or view it on GitHub< https://github.com/JamesGlanville/GF2/issues/19> .

— Reply to this email directly or view it on GitHubhttps://github.com/JamesGlanville/GF2/issues/19#issuecomment-18718561 .

JamesGlanville commented 11 years ago

looks good here. Still getting the occasional thing where the gui doesn't appear, but otherwise great.

On 31 May 2013 02:40, GeorgeAyris notifications@github.com wrote:

Do you mind just checking what I've done works?

On 31 May 2013 02:25, James Glanville notifications@github.com wrote:

Definitely good if possible though.

On 31 May 2013 02:25, James Glanville james.n.glanville@gmail.com wrote:

I had a look at doing this and thought it was tricky, do we have time?

On 31 May 2013 02:18, GeorgeAyris notifications@github.com wrote:

Say if you have just set switch a to high and want to set switch b to high then you have to select switch b then select low and then select high.

Propose if you select a different switch it alters the value then (more preferable, but harder would be to for the high/low drop down to default to the current value of the switch).

Hope this makes sense.

— Reply to this email directly or view it on GitHub< https://github.com/JamesGlanville/GF2/issues/19> .

— Reply to this email directly or view it on GitHub< https://github.com/JamesGlanville/GF2/issues/19#issuecomment-18718561> .

— Reply to this email directly or view it on GitHubhttps://github.com/JamesGlanville/GF2/issues/19#issuecomment-18718953 .

AndyHolt commented 11 years ago

My plan was to lookup the current value of the switch selected and show that unless you change it, but there is no simple method for doing this, hence the slightly rubbish method in place. I think it would be simple enough to add the functions to devices as with isswitch stuff to make it work, but I didn't think there was any point in doing it last night (I'm just seeing this this morning...)

AndyHolt commented 11 years ago

I'm guessing this won't get done, but I'll add it to the gui stuff just in case