search

JamesGlanville / GF2

0 stars 0 forks source link

Who broke scrolling? #24

Open AndyHolt opened 11 years ago

AndyHolt commented 11 years ago

Just pulled the latest code from github, there doesn't seem to be any option to add the monitors defined in the spec file and vertical scrolling doesn't work any more.

Don't mean to sound blame-y but does anyone know when these stopped working and how easy it would be to change it back without breaking something else?

ghost commented 11 years ago

Judging by the last commits it happened when Glanville sorted out the monitor adding, if it was working on your last commit. Also, the render call with no parameters is still in OnPaint and I'm not sure what entirely wants doing with it... apart from the fact it needs changing otherwise the traces will still be overwritten.

ghost commented 11 years ago

Also is there a command to reset the switch and monitor lists that we can put in the load devices button?

AndyHolt commented 11 years ago

James, any idea what when wrong?

Basically, I've pretty much just started my report so I'm not planning on doing any more development or bug fixing. If there are any easy fixes it might be worth it but I don't want to waste time on getting an extra mark or two when the report is worth 50.

For the switch and monitor lists, if its just the combo boxes that need changed, use the wxComboBox*->Remove(first, last) function. I can't remember off the top of my head exactly what to use for first and last (sorry!), but I'm pretty sure there's a similar thing done in the addmonitor or remmonitor (might be called something slightly different but obviously these) functions at the end of gui.cc

If its to do with the device and monitor classes then I don't really know what to do with those, I won't mind if you leave it as is!

AndyHolt commented 11 years ago

Also, did you make any progress on the traces not drawing properly issue?

ghost commented 11 years ago

I think commenting out the render call in onpaint seems to solve the issue, but not sure if it introduces unwanted side effects.

JamesGlanville commented 11 years ago

Sorry about this, I went to sleep thinking everything was fine :( ill try and fix it this morning. Does anyone know where the shared directory is? We need to put the code there later.

On 6 Jun 2013, at 00:44, GeorgeAyris notifications@github.com wrote:

I think commenting out the render call in onpaint seems to solve the issue, but not sure if it introduces unwanted side effects.

— Reply to this email directly or view it on GitHubhttps://github.com/JamesGlanville/GF2/issues/24#issuecomment-19016562 .

AndyHolt commented 11 years ago

No worries, don't worry if you can't fix it - the report is worth much more than the system.

There's a link to the shared directory in each of our home folders on the teaching system: ~/GF2_shared

ghost commented 11 years ago

I asked this before, but do we have all the resources for a complete appendix B?

On 6 June 2013 10:37, adh635 notifications@github.com wrote:

No worries, don't worry if you can't fix it - the report is worth much more than the system.

There's a link to the shared directory in each of our home folders on the teaching system: ~/GF2_shared

— Reply to this email directly or view it on GitHubhttps://github.com/JamesGlanville/GF2/issues/24#issuecomment-19034484 .

AndyHolt commented 11 years ago

We have testgates, shift_register and siggen files, and definitely circuit diagrams for the first two - do we have a siggen diagram? If not, I don't want to dump it on you James, but I'm guessing you could do it faster than me, do you have time? This is higher priority than working code.

For the test results obtained, we can just grab screenshots of the system running on each test file. I'm happy to get these, probably just after lunch, and put them on git if they haven't been done already by anyone?

AndyHolt commented 11 years ago

George: I've discovered the unwanted side effect of commenting out the render call: the traces don't redraw when the window is resized, so if you shrink the window then pull it out again, the traces simply disappear...

ghost commented 11 years ago

Oh yeah I sort of mentioned this in the other thread, but wasn't very clear. Not sure what to suggest because putting the correct render call there will take quite a lot of work.

AndyHolt commented 11 years ago

Yeah, I'm just going to leave it an mention it in the report.

JamesGlanville commented 11 years ago

I'll get the signal generator schematic drawn up asap.

On 6 June 2013 11:21, adh635 notifications@github.com wrote:

Yeah, I'm just going to leave it an mention it in the report.

— Reply to this email directly or view it on GitHubhttps://github.com/JamesGlanville/GF2/issues/24#issuecomment-19036461 .

JamesGlanville commented 11 years ago

it's here: http://i.imgur.com/ii3r0J7.png

On 6 June 2013 12:02, James Glanville james.n.glanville@gmail.com wrote:

I'll get the signal generator schematic drawn up asap.

On 6 June 2013 11:21, adh635 notifications@github.com wrote:

Yeah, I'm just going to leave it an mention it in the report.

— Reply to this email directly or view it on GitHubhttps://github.com/JamesGlanville/GF2/issues/24#issuecomment-19036461 .

AndyHolt commented 11 years ago

Cool, thanks!

ghost commented 11 years ago

I was just trialling some things to write an updated user guide and it doesn't seem to work well at all... e.g. switching the state of switch a does not cause the monitor state to change and I can't get two traces on screen that display different things. Is there a slightly earlier revision we can revert to?

Thanks for the circuit diagram!

On 6 June 2013 12:10, adh635 notifications@github.com wrote:

Cool, thanks!

— Reply to this email directly or view it on GitHubhttps://github.com/JamesGlanville/GF2/issues/24#issuecomment-19038475 .