Closed ghost closed 11 years ago
JamesGlanville
commented
11 years ago does it work now?
On 29 May 2013 12:48, GeorgeAyris notifications@github.com wrote:
Reminder
— Reply to this email directly or view it on GitHubhttps://github.com/JamesGlanville/GF2/issues/9 .
ghost
commented
11 years ago Don't think so - you can test by running parser_test with test3.txt and it should give you the errors specified (line 6 and 7).
On 29 May 2013 12:55, James Glanville notifications@github.com wrote:
does it work now?
On 29 May 2013 12:48, GeorgeAyris notifications@github.com wrote:
Reminder
— Reply to this email directly or view it on GitHub< https://github.com/JamesGlanville/GF2/issues/9> .
— Reply to this email directly or view it on GitHubhttps://github.com/JamesGlanville/GF2/issues/9#issuecomment-18611354 .
JamesGlanville
commented
11 years ago I get:
Expected errors: invalid device type line 6 invalid param line 7
Error: Not a valid device type on line 6 at location (startat0) 8: dtyp=dtyp; ^ Error: Expected device name on line 10 at location (startat0) 0:
Error count is 2 1
what is the expected output and what is it doing wrong? I'm a little confused.
On 29 May 2013 13:36, GeorgeAyris notifications@github.com wrote:
Don't think so - you can test by running parser_test with test3.txt and it should give you the errors specified (line 6 and 7).
On 29 May 2013 12:55, James Glanville notifications@github.com wrote:
does it work now?
On 29 May 2013 12:48, GeorgeAyris notifications@github.com wrote:
Reminder
— Reply to this email directly or view it on GitHub< https://github.com/JamesGlanville/GF2/issues/9> .
— Reply to this email directly or view it on GitHub< https://github.com/JamesGlanville/GF2/issues/9#issuecomment-18611354> .
— Reply to this email directly or view it on GitHubhttps://github.com/JamesGlanville/GF2/issues/9#issuecomment-18613226 .
ghost
commented
11 years ago I've got the latest git version and it's still skipping the semi-colon... That seems to be working at your end.
On 29 May 2013 13:47, James Glanville notifications@github.com wrote:
I get:
Expected errors: invalid device type line 6 invalid param line 7
Error: Not a valid device type on line 6 at location (startat0) 8: dtyp=dtyp; ^ Error: Expected device name on line 10 at location (startat0) 0:
Error count is 2 1
what is the expected output and what is it doing wrong? I'm a little confused.
On 29 May 2013 13:36, GeorgeAyris notifications@github.com wrote:
Don't think so - you can test by running parser_test with test3.txt and it should give you the errors specified (line 6 and 7).
On 29 May 2013 12:55, James Glanville notifications@github.com wrote:
does it work now?
On 29 May 2013 12:48, GeorgeAyris notifications@github.com wrote:
Reminder
— Reply to this email directly or view it on GitHub< https://github.com/JamesGlanville/GF2/issues/9> .
— Reply to this email directly or view it on GitHub< https://github.com/JamesGlanville/GF2/issues/9#issuecomment-18611354> .
— Reply to this email directly or view it on GitHub< https://github.com/JamesGlanville/GF2/issues/9#issuecomment-18613226> .
— Reply to this email directly or view it on GitHubhttps://github.com/JamesGlanville/GF2/issues/9#issuecomment-18613770 .
JamesGlanville
commented
11 years ago Now I'm really confused :s it shows my latest commit on github.com(59b3e51cf567d36a015ac7a7f683f2a03c9bcb07) is that the one you're on (git log will say what the latest commit is)
On 29 May 2013 13:48, GeorgeAyris notifications@github.com wrote:
I've got the latest git version and it's still skipping the semi-colon... That seems to be working at your end.
On 29 May 2013 13:47, James Glanville notifications@github.com wrote:
I get:
Expected errors: invalid device type line 6 invalid param line 7
Error: Not a valid device type on line 6 at location (startat0) 8: dtyp=dtyp; ^ Error: Expected device name on line 10 at location (startat0) 0:
Error count is 2 1
what is the expected output and what is it doing wrong? I'm a little confused.
On 29 May 2013 13:36, GeorgeAyris notifications@github.com wrote:
Don't think so - you can test by running parser_test with test3.txt and it should give you the errors specified (line 6 and 7).
On 29 May 2013 12:55, James Glanville notifications@github.com wrote:
does it work now?
On 29 May 2013 12:48, GeorgeAyris notifications@github.com wrote:
Reminder
— Reply to this email directly or view it on GitHub< https://github.com/JamesGlanville/GF2/issues/9> .
— Reply to this email directly or view it on GitHub< https://github.com/JamesGlanville/GF2/issues/9#issuecomment-18611354> .
— Reply to this email directly or view it on GitHub< https://github.com/JamesGlanville/GF2/issues/9#issuecomment-18613226> .
— Reply to this email directly or view it on GitHub< https://github.com/JamesGlanville/GF2/issues/9#issuecomment-18613770> .
— Reply to this email directly or view it on GitHubhttps://github.com/JamesGlanville/GF2/issues/9#issuecomment-18613824 .
ghost
commented
11 years ago Yeah it shows that as the top entry in git log. I can't think what I am doing wrong.
On 29 May 2013 13:50, James Glanville notifications@github.com wrote:
Now I'm really confused :s it shows my latest commit on github.com(59b3e51cf567d36a015ac7a7f683f2a03c9bcb07) is that the one you're on (git log will say what the latest commit is)
On 29 May 2013 13:48, GeorgeAyris notifications@github.com wrote:
I've got the latest git version and it's still skipping the semi-colon... That seems to be working at your end.
On 29 May 2013 13:47, James Glanville notifications@github.com wrote:
I get:
Expected errors: invalid device type line 6 invalid param line 7
Error: Not a valid device type on line 6 at location (startat0) 8: dtyp=dtyp; ^ Error: Expected device name on line 10 at location (startat0) 0:
Error count is 2 1
what is the expected output and what is it doing wrong? I'm a little confused.
On 29 May 2013 13:36, GeorgeAyris notifications@github.com wrote:
Don't think so - you can test by running parser_test with test3.txt and it should give you the errors specified (line 6 and 7).
On 29 May 2013 12:55, James Glanville notifications@github.com wrote:
does it work now?
On 29 May 2013 12:48, GeorgeAyris notifications@github.com wrote:
Reminder
— Reply to this email directly or view it on GitHub< https://github.com/JamesGlanville/GF2/issues/9> .
— Reply to this email directly or view it on GitHub< https://github.com/JamesGlanville/GF2/issues/9#issuecomment-18611354>
.
— Reply to this email directly or view it on GitHub< https://github.com/JamesGlanville/GF2/issues/9#issuecomment-18613226> .
— Reply to this email directly or view it on GitHub< https://github.com/JamesGlanville/GF2/issues/9#issuecomment-18613770> .
— Reply to this email directly or view it on GitHub< https://github.com/JamesGlanville/GF2/issues/9#issuecomment-18613824> .
— Reply to this email directly or view it on GitHubhttps://github.com/JamesGlanville/GF2/issues/9#issuecomment-18613949 .
ghost
commented
11 years ago Oh sorry, just re-read the email conversation. You should be getting an error on line 7 about invalid parameters, otherwise it's still gobbling the semi-colon. Sorry I didn't notice that the first time.
On 29 May 2013 13:55, George Ayris georgeayris@gmail.com wrote:
Yeah it shows that as the top entry in git log. I can't think what I am doing wrong.
On 29 May 2013 13:50, James Glanville notifications@github.com wrote:
Now I'm really confused :s it shows my latest commit on github.com(59b3e51cf567d36a015ac7a7f683f2a03c9bcb07) is that the one you're on (git log will say what the latest commit is)
On 29 May 2013 13:48, GeorgeAyris notifications@github.com wrote:
I've got the latest git version and it's still skipping the semi-colon... That seems to be working at your end.
On 29 May 2013 13:47, James Glanville notifications@github.com wrote:
I get:
Expected errors: invalid device type line 6 invalid param line 7
Error: Not a valid device type on line 6 at location (startat0) 8: dtyp=dtyp; ^ Error: Expected device name on line 10 at location (startat0) 0:
Error count is 2 1
what is the expected output and what is it doing wrong? I'm a little confused.
On 29 May 2013 13:36, GeorgeAyris notifications@github.com wrote:
Don't think so - you can test by running parser_test with test3.txt and it should give you the errors specified (line 6 and 7).
On 29 May 2013 12:55, James Glanville notifications@github.com wrote:
does it work now?
On 29 May 2013 12:48, GeorgeAyris notifications@github.com wrote:
Reminder
— Reply to this email directly or view it on GitHub< https://github.com/JamesGlanville/GF2/issues/9> .
— Reply to this email directly or view it on GitHub<
https://github.com/JamesGlanville/GF2/issues/9#issuecomment-18611354>
.
— Reply to this email directly or view it on GitHub< https://github.com/JamesGlanville/GF2/issues/9#issuecomment-18613226>
.
— Reply to this email directly or view it on GitHub< https://github.com/JamesGlanville/GF2/issues/9#issuecomment-18613770> .
— Reply to this email directly or view it on GitHub< https://github.com/JamesGlanville/GF2/issues/9#issuecomment-18613824> .
— Reply to this email directly or view it on GitHubhttps://github.com/JamesGlanville/GF2/issues/9#issuecomment-18613949 .
ghost
commented
11 years ago If you comment out errorHandling(not_valid_device) on line 824 of parser.cc then remake it displays the error that is getting missed because it's not resuming parsing at the first semi-colon.
On 29 May 2013 13:58, George Ayris georgeayris@gmail.com wrote:
Oh sorry, just re-read the email conversation. You should be getting an error on line 7 about invalid parameters, otherwise it's still gobbling the semi-colon. Sorry I didn't notice that the first time.
On 29 May 2013 13:55, George Ayris georgeayris@gmail.com wrote:
Yeah it shows that as the top entry in git log. I can't think what I am doing wrong.
On 29 May 2013 13:50, James Glanville notifications@github.com wrote:
Now I'm really confused :s it shows my latest commit on github.com(59b3e51cf567d36a015ac7a7f683f2a03c9bcb07) is that the one you're on (git log will say what the latest commit is)
On 29 May 2013 13:48, GeorgeAyris notifications@github.com wrote:
I've got the latest git version and it's still skipping the semi-colon... That seems to be working at your end.
On 29 May 2013 13:47, James Glanville notifications@github.com wrote:
I get:
Expected errors: invalid device type line 6 invalid param line 7
Error: Not a valid device type on line 6 at location (startat0) 8: dtyp=dtyp; ^ Error: Expected device name on line 10 at location (startat0) 0:
Error count is 2 1
what is the expected output and what is it doing wrong? I'm a little confused.
On 29 May 2013 13:36, GeorgeAyris notifications@github.com wrote:
Don't think so - you can test by running parser_test with test3.txt and it should give you the errors specified (line 6 and 7).
On 29 May 2013 12:55, James Glanville notifications@github.com wrote:
does it work now?
On 29 May 2013 12:48, GeorgeAyris notifications@github.com wrote:
Reminder
— Reply to this email directly or view it on GitHub< https://github.com/JamesGlanville/GF2/issues/9> .
— Reply to this email directly or view it on GitHub<
https://github.com/JamesGlanville/GF2/issues/9#issuecomment-18611354>
.
— Reply to this email directly or view it on GitHub< https://github.com/JamesGlanville/GF2/issues/9#issuecomment-18613226>
.
— Reply to this email directly or view it on GitHub< https://github.com/JamesGlanville/GF2/issues/9#issuecomment-18613770> .
— Reply to this email directly or view it on GitHub< https://github.com/JamesGlanville/GF2/issues/9#issuecomment-18613824> .
— Reply to this email directly or view it on GitHubhttps://github.com/JamesGlanville/GF2/issues/9#issuecomment-18613949 .
JamesGlanville
commented
11 years ago I've commented it out, and get:
Expected errors: invalid device type line 6 invalid param line 7
Error: Not a valid device type on line 6 at location (startat0) 8: dtyp=dtyp; ^ Error: Expected device name on line 10 at location (startat0) 0:
Error count is 2 1
which I think is the same as before :s
On 29 May 2013 14:00, GeorgeAyris notifications@github.com wrote:
If you comment out errorHandling(not_valid_device) on line 824 of parser.cc then remake it displays the error that is getting missed because it's not resuming parsing at the first semi-colon.
On 29 May 2013 13:58, George Ayris georgeayris@gmail.com wrote:
Oh sorry, just re-read the email conversation. You should be getting an error on line 7 about invalid parameters, otherwise it's still gobbling the semi-colon. Sorry I didn't notice that the first time.
On 29 May 2013 13:55, George Ayris georgeayris@gmail.com wrote:
Yeah it shows that as the top entry in git log. I can't think what I am doing wrong.
On 29 May 2013 13:50, James Glanville notifications@github.com wrote:
Now I'm really confused :s it shows my latest commit on github.com(59b3e51cf567d36a015ac7a7f683f2a03c9bcb07) is that the one you're on (git log will say what the latest commit is)
On 29 May 2013 13:48, GeorgeAyris notifications@github.com wrote:
I've got the latest git version and it's still skipping the semi-colon... That seems to be working at your end.
On 29 May 2013 13:47, James Glanville notifications@github.com wrote:
I get:
Expected errors: invalid device type line 6 invalid param line 7
Error: Not a valid device type on line 6 at location (startat0) 8: dtyp=dtyp; ^ Error: Expected device name on line 10 at location (startat0) 0:
Error count is 2 1
what is the expected output and what is it doing wrong? I'm a little confused.
On 29 May 2013 13:36, GeorgeAyris notifications@github.com wrote:
Don't think so - you can test by running parser_test with test3.txt and it should give you the errors specified (line 6 and 7).
On 29 May 2013 12:55, James Glanville notifications@github.com
wrote:
does it work now?
On 29 May 2013 12:48, GeorgeAyris notifications@github.com wrote:
Reminder
— Reply to this email directly or view it on GitHub< https://github.com/JamesGlanville/GF2/issues/9> .
— Reply to this email directly or view it on GitHub<
https://github.com/JamesGlanville/GF2/issues/9#issuecomment-18611354>
.
— Reply to this email directly or view it on GitHub<
https://github.com/JamesGlanville/GF2/issues/9#issuecomment-18613226>
.
— Reply to this email directly or view it on GitHub< https://github.com/JamesGlanville/GF2/issues/9#issuecomment-18613770>
.
— Reply to this email directly or view it on GitHub< https://github.com/JamesGlanville/GF2/issues/9#issuecomment-18613824> .
— Reply to this email directly or view it on GitHub< https://github.com/JamesGlanville/GF2/issues/9#issuecomment-18613949> .
— Reply to this email directly or view it on GitHubhttps://github.com/JamesGlanville/GF2/issues/9#issuecomment-18614423 .
JamesGlanville
commented
11 years ago oh missed your second last comment, i'll check.
On 29 May 2013 14:54, James Glanville james.n.glanville@gmail.com wrote:
I've commented it out, and get:
Expected errors: invalid device type line 6 invalid param line 7
Error: Not a valid device type on line 6 at location (startat0) 8: dtyp=dtyp; ^ Error: Expected device name on line 10 at location (startat0) 0:
Error count is 2 1
which I think is the same as before :s
On 29 May 2013 14:00, GeorgeAyris notifications@github.com wrote:
If you comment out errorHandling(not_valid_device) on line 824 of parser.cc then remake it displays the error that is getting missed because it's not resuming parsing at the first semi-colon.
On 29 May 2013 13:58, George Ayris georgeayris@gmail.com wrote:
Oh sorry, just re-read the email conversation. You should be getting an error on line 7 about invalid parameters, otherwise it's still gobbling the semi-colon. Sorry I didn't notice that the first time.
On 29 May 2013 13:55, George Ayris georgeayris@gmail.com wrote:
Yeah it shows that as the top entry in git log. I can't think what I am doing wrong.
On 29 May 2013 13:50, James Glanville notifications@github.com wrote:
Now I'm really confused :s it shows my latest commit on github.com(59b3e51cf567d36a015ac7a7f683f2a03c9bcb07) is that the one you're on (git log will say what the latest commit is)
On 29 May 2013 13:48, GeorgeAyris notifications@github.com wrote:
I've got the latest git version and it's still skipping the semi-colon... That seems to be working at your end.
On 29 May 2013 13:47, James Glanville notifications@github.com wrote:
I get:
Expected errors: invalid device type line 6 invalid param line 7
Error: Not a valid device type on line 6 at location (startat0) 8: dtyp=dtyp; ^ Error: Expected device name on line 10 at location (startat0) 0:
Error count is 2 1
what is the expected output and what is it doing wrong? I'm a little confused.
On 29 May 2013 13:36, GeorgeAyris notifications@github.com wrote:
Don't think so - you can test by running parser_test with test3.txt and it should give you the errors specified (line 6 and 7).
On 29 May 2013 12:55, James Glanville notifications@github.com
wrote:
does it work now?
On 29 May 2013 12:48, GeorgeAyris notifications@github.com wrote:
Reminder
— Reply to this email directly or view it on GitHub< https://github.com/JamesGlanville/GF2/issues/9> .
— Reply to this email directly or view it on GitHub<
https://github.com/JamesGlanville/GF2/issues/9#issuecomment-18611354>
.
— Reply to this email directly or view it on GitHub<
https://github.com/JamesGlanville/GF2/issues/9#issuecomment-18613226>
.
— Reply to this email directly or view it on GitHub<
https://github.com/JamesGlanville/GF2/issues/9#issuecomment-18613770>
.
— Reply to this email directly or view it on GitHub< https://github.com/JamesGlanville/GF2/issues/9#issuecomment-18613824>
.
— Reply to this email directly or view it on GitHub< https://github.com/JamesGlanville/GF2/issues/9#issuecomment-18613949> .
— Reply to this email directly or view it on GitHubhttps://github.com/JamesGlanville/GF2/issues/9#issuecomment-18614423 .
ghost
commented
11 years ago Any luck? Do you want me to do anything?
On 29 May 2013 14:55, James Glanville notifications@github.com wrote:
oh missed your second last comment, i'll check.
On 29 May 2013 14:54, James Glanville james.n.glanville@gmail.com wrote:
I've commented it out, and get:
Expected errors: invalid device type line 6 invalid param line 7
Error: Not a valid device type on line 6 at location (startat0) 8: dtyp=dtyp; ^ Error: Expected device name on line 10 at location (startat0) 0:
Error count is 2 1
which I think is the same as before :s
On 29 May 2013 14:00, GeorgeAyris notifications@github.com wrote:
If you comment out errorHandling(not_valid_device) on line 824 of parser.cc then remake it displays the error that is getting missed because it's not resuming parsing at the first semi-colon.
On 29 May 2013 13:58, George Ayris georgeayris@gmail.com wrote:
Oh sorry, just re-read the email conversation. You should be getting an error on line 7 about invalid parameters, otherwise it's still gobbling the semi-colon. Sorry I didn't notice that the first time.
On 29 May 2013 13:55, George Ayris georgeayris@gmail.com wrote:
Yeah it shows that as the top entry in git log. I can't think what I am doing wrong.
On 29 May 2013 13:50, James Glanville notifications@github.com wrote:
Now I'm really confused :s it shows my latest commit on github.com(59b3e51cf567d36a015ac7a7f683f2a03c9bcb07) is that the one you're on (git log will say what the latest commit is)
On 29 May 2013 13:48, GeorgeAyris notifications@github.com wrote:
I've got the latest git version and it's still skipping the semi-colon... That seems to be working at your end.
On 29 May 2013 13:47, James Glanville notifications@github.com wrote:
I get:
Expected errors: invalid device type line 6 invalid param line 7
Error: Not a valid device type on line 6 at location (startat0) 8: dtyp=dtyp; ^ Error: Expected device name on line 10 at location (startat0) 0:
Error count is 2 1
what is the expected output and what is it doing wrong? I'm a little confused.
On 29 May 2013 13:36, GeorgeAyris notifications@github.com wrote:
Don't think so - you can test by running parser_test with test3.txt and it should give you the errors specified (line 6 and 7).
On 29 May 2013 12:55, James Glanville < notifications@github.com>
wrote:
does it work now?
On 29 May 2013 12:48, GeorgeAyris notifications@github.com
wrote:
Reminder
— Reply to this email directly or view it on GitHub< https://github.com/JamesGlanville/GF2/issues/9> .
— Reply to this email directly or view it on GitHub<
https://github.com/JamesGlanville/GF2/issues/9#issuecomment-18611354>
.
— Reply to this email directly or view it on GitHub<
https://github.com/JamesGlanville/GF2/issues/9#issuecomment-18613226>
.
— Reply to this email directly or view it on GitHub<
https://github.com/JamesGlanville/GF2/issues/9#issuecomment-18613770>
.
— Reply to this email directly or view it on GitHub<
https://github.com/JamesGlanville/GF2/issues/9#issuecomment-18613824>
.
— Reply to this email directly or view it on GitHub< https://github.com/JamesGlanville/GF2/issues/9#issuecomment-18613949> .
— Reply to this email directly or view it on GitHub< https://github.com/JamesGlanville/GF2/issues/9#issuecomment-18614423> .
— Reply to this email directly or view it on GitHubhttps://github.com/JamesGlanville/GF2/issues/9#issuecomment-18617690 .
JamesGlanville
commented
11 years ago oh sorry i've taken so long :( Is this right?
Expected errors: invalid device type line 6 invalid param line 7
Error: Gate requires between 2 and 16 inputs on line 7 at location (startat0) 13: aAa = NAND(17); ^ Error: Expected device name on line 10 at location (startat0) 0:
Error count is 3 1
(this is in git now, with the error thing you said commented out.)
On 29 May 2013 15:29, GeorgeAyris notifications@github.com wrote:
Any luck? Do you want me to do anything?
On 29 May 2013 14:55, James Glanville notifications@github.com wrote:
oh missed your second last comment, i'll check.
On 29 May 2013 14:54, James Glanville james.n.glanville@gmail.com wrote:
I've commented it out, and get:
Expected errors: invalid device type line 6 invalid param line 7
Error: Not a valid device type on line 6 at location (startat0) 8: dtyp=dtyp; ^ Error: Expected device name on line 10 at location (startat0) 0:
Error count is 2 1
which I think is the same as before :s
On 29 May 2013 14:00, GeorgeAyris notifications@github.com wrote:
If you comment out errorHandling(not_valid_device) on line 824 of parser.cc then remake it displays the error that is getting missed because it's not resuming parsing at the first semi-colon.
On 29 May 2013 13:58, George Ayris georgeayris@gmail.com wrote:
Oh sorry, just re-read the email conversation. You should be getting an error on line 7 about invalid parameters, otherwise it's still gobbling the semi-colon. Sorry I didn't notice that the first time.
On 29 May 2013 13:55, George Ayris georgeayris@gmail.com wrote:
Yeah it shows that as the top entry in git log. I can't think what I am doing wrong.
On 29 May 2013 13:50, James Glanville notifications@github.com wrote:
Now I'm really confused :s it shows my latest commit on github.com(59b3e51cf567d36a015ac7a7f683f2a03c9bcb07) is that the one you're on (git log will say what the latest commit is)
On 29 May 2013 13:48, GeorgeAyris notifications@github.com wrote:
I've got the latest git version and it's still skipping the semi-colon... That seems to be working at your end.
On 29 May 2013 13:47, James Glanville notifications@github.com
wrote:
I get:
Expected errors: invalid device type line 6 invalid param line 7
Error: Not a valid device type on line 6 at location (startat0) 8: dtyp=dtyp; ^ Error: Expected device name on line 10 at location (startat0) 0:
Error count is 2 1
what is the expected output and what is it doing wrong? I'm a little confused.
On 29 May 2013 13:36, GeorgeAyris notifications@github.com wrote:
Don't think so - you can test by running parser_test with test3.txt and it should give you the errors specified (line 6 and 7).
On 29 May 2013 12:55, James Glanville < notifications@github.com>
wrote:
does it work now?
On 29 May 2013 12:48, GeorgeAyris < notifications@github.com>
wrote:
Reminder
— Reply to this email directly or view it on GitHub< https://github.com/JamesGlanville/GF2/issues/9> .
— Reply to this email directly or view it on GitHub<
https://github.com/JamesGlanville/GF2/issues/9#issuecomment-18611354>
.
— Reply to this email directly or view it on GitHub<
https://github.com/JamesGlanville/GF2/issues/9#issuecomment-18613226>
.
— Reply to this email directly or view it on GitHub<
https://github.com/JamesGlanville/GF2/issues/9#issuecomment-18613770>
.
— Reply to this email directly or view it on GitHub<
https://github.com/JamesGlanville/GF2/issues/9#issuecomment-18613824>
.
— Reply to this email directly or view it on GitHub< https://github.com/JamesGlanville/GF2/issues/9#issuecomment-18613949>
.
— Reply to this email directly or view it on GitHub< https://github.com/JamesGlanville/GF2/issues/9#issuecomment-18614423> .
— Reply to this email directly or view it on GitHub< https://github.com/JamesGlanville/GF2/issues/9#issuecomment-18617690> .
— Reply to this email directly or view it on GitHubhttps://github.com/JamesGlanville/GF2/issues/9#issuecomment-18620046 .
ghost
commented
11 years ago Yeah that's error that should be generated.
On 29 May 2013 15:43, James Glanville notifications@github.com wrote:
oh sorry i've taken so long :( Is this right?
Expected errors: invalid device type line 6 invalid param line 7
Error: Gate requires between 2 and 16 inputs on line 7 at location (startat0) 13: aAa = NAND(17); ^ Error: Expected device name on line 10 at location (startat0) 0:
Error count is 3 1
(this is in git now, with the error thing you said commented out.)
On 29 May 2013 15:29, GeorgeAyris notifications@github.com wrote:
Any luck? Do you want me to do anything?
On 29 May 2013 14:55, James Glanville notifications@github.com wrote:
oh missed your second last comment, i'll check.
On 29 May 2013 14:54, James Glanville james.n.glanville@gmail.com wrote:
I've commented it out, and get:
Expected errors: invalid device type line 6 invalid param line 7
Error: Not a valid device type on line 6 at location (startat0) 8: dtyp=dtyp; ^ Error: Expected device name on line 10 at location (startat0) 0:
Error count is 2 1
which I think is the same as before :s
On 29 May 2013 14:00, GeorgeAyris notifications@github.com wrote:
If you comment out errorHandling(not_valid_device) on line 824 of parser.cc then remake it displays the error that is getting missed because it's not resuming parsing at the first semi-colon.
On 29 May 2013 13:58, George Ayris georgeayris@gmail.com wrote:
Oh sorry, just re-read the email conversation. You should be getting an error on line 7 about invalid parameters, otherwise it's still gobbling the semi-colon. Sorry I didn't notice that the first time.
On 29 May 2013 13:55, George Ayris georgeayris@gmail.com wrote:
Yeah it shows that as the top entry in git log. I can't think what I am doing wrong.
On 29 May 2013 13:50, James Glanville notifications@github.com
wrote:
Now I'm really confused :s it shows my latest commit on github.com(59b3e51cf567d36a015ac7a7f683f2a03c9bcb07) is that the one you're on (git log will say what the latest commit is)
On 29 May 2013 13:48, GeorgeAyris notifications@github.com wrote:
I've got the latest git version and it's still skipping the semi-colon... That seems to be working at your end.
On 29 May 2013 13:47, James Glanville < notifications@github.com>
wrote:
I get:
Expected errors: invalid device type line 6 invalid param line 7
Error: Not a valid device type on line 6 at location (startat0) 8: dtyp=dtyp; ^ Error: Expected device name on line 10 at location (startat0) 0:
Error count is 2 1
what is the expected output and what is it doing wrong? I'm a little confused.
On 29 May 2013 13:36, GeorgeAyris notifications@github.com
wrote:
Don't think so - you can test by running parser_test with test3.txt and it should give you the errors specified (line 6 and 7).
On 29 May 2013 12:55, James Glanville < notifications@github.com>
wrote:
does it work now?
On 29 May 2013 12:48, GeorgeAyris < notifications@github.com>
wrote:
Reminder
— Reply to this email directly or view it on GitHub< https://github.com/JamesGlanville/GF2/issues/9> .
— Reply to this email directly or view it on GitHub<
https://github.com/JamesGlanville/GF2/issues/9#issuecomment-18611354>
.
— Reply to this email directly or view it on GitHub<
https://github.com/JamesGlanville/GF2/issues/9#issuecomment-18613226>
.
— Reply to this email directly or view it on GitHub<
https://github.com/JamesGlanville/GF2/issues/9#issuecomment-18613770>
.
— Reply to this email directly or view it on GitHub<
https://github.com/JamesGlanville/GF2/issues/9#issuecomment-18613824>
.
— Reply to this email directly or view it on GitHub<
https://github.com/JamesGlanville/GF2/issues/9#issuecomment-18613949>
.
— Reply to this email directly or view it on GitHub< https://github.com/JamesGlanville/GF2/issues/9#issuecomment-18614423> .
— Reply to this email directly or view it on GitHub< https://github.com/JamesGlanville/GF2/issues/9#issuecomment-18617690> .
— Reply to this email directly or view it on GitHub< https://github.com/JamesGlanville/GF2/issues/9#issuecomment-18620046> .
— Reply to this email directly or view it on GitHubhttps://github.com/JamesGlanville/GF2/issues/9#issuecomment-18621135 .
JamesGlanville
commented
11 years ago I think that's sorted now, it gives the 3 errors without commenting out that printerror line. Could you test to see if that's ok? sorry i've been so slow.
ghost
commented
11 years ago Looks to be working, good job! No worries on speed.
On 29 May 2013 15:54, James Glanville notifications@github.com wrote:
I think that's sorted now, it gives the 3 errors without commenting out that printerror line. Could you test to see if that's ok? sorry i've been so slow.
— Reply to this email directly or view it on GitHubhttps://github.com/JamesGlanville/GF2/issues/9#issuecomment-18621895 .
Reminder