JamesHarrison / openob

The Open Outside Broadcast project for radio contribution links and studio-transmitter links.
158 stars 34 forks source link

Fail to set UDP Port in receiver #33

Closed EduardoRicobaldi closed 6 years ago

EduardoRicobaldi commented 6 years ago

Port number is a transmitter parameter, but receiver use only default port 3000. To set port parameter in tx and rx, move out of tx arguments.

EGG-INFO/scripts/openob

parser.add_argument('link_name', type=str, help="The link name this OpenOB Manager is operating on; must be the same on both Nodes")
parser.add_argument('-p', '--port', type=int, default=3000, help="The base port to use for audio transport. This port must be accessible on the receiving host")
subparsers = parser.add_subparsers(help="The link mode to operate in on this end")

openob/link_config.py

        self.set("name", opts.link_name)
        self.set("port", opts.port)
        if opts.mode == "tx":
            self.set("jitter_buffer", opts.jitter_buffer)

Now the new usage: usage: openob [-h] [-v] [-p PORT] config_host node_name link_name {tx,rx} ...

Maybe some docs will be update too.

Great work, thanks!

PS: Sorry my English and very new in Git to pull well.

EduardoRicobaldi commented 6 years ago

Sorry, receiver port is taken from redis database. Testing many streams at time, and a database never cleanup at closed transmission.