Closed GoogleCodeExporter closed 9 years ago
We agreed to do this. It will get rid of nasty
ConfigurationParameterFactory.createConfigurationParameterName calls.
Original comment by steven.b...@gmail.com
on 25 Jun 2013 at 5:36
Original comment by phi...@ogren.info
on 25 Jun 2013 at 8:29
I made good progress on this yesterday and worked on it some more last night.
I worked out a problem with the parameters test and it seems to work now
because it found a bunch of find/replace cases that I missed. I will clean
these up and push the branch asap.
Original comment by phi...@ogren.info
on 26 Jun 2013 at 12:55
fixed in revision f2360538dc085a4609374f33d4c4d7a3e851471f.
Original comment by phi...@ogren.info
on 30 Jun 2013 at 4:19
Looks like some of the ClearNLP tests are failing:
https://drone.io/bethard/cleartk/214
Original comment by steven.b...@gmail.com
on 30 Jun 2013 at 2:28
Looks like there were some newline issues in the tests. The problem was
introduced by the fix for this issue, as \r characters were added to the
tokenization test files.
I fixed this in 2ceb7497e3a60f061f02b0b1b061ce769858b3ca by getting rid of
those text files and putting the testing strings directly into the code. That
should avoid newline problems in the future as well.
Original comment by steven.b...@gmail.com
on 1 Jul 2013 at 8:27
Thanks for finding this and fixing it! I'm pretty sure those tests weren't
failing for me on my Windows box.
Original comment by phi...@ogren.info
on 2 Jul 2013 at 12:54
No, they wouldn't have been failing on Windows - you checked in Windows-style
newlines for the files dollars.txt, marysdog.txt, etc. I think the only ways to
catch this is to either (1) notice you're checking in a bunch of .txt files
that you don't remember modifying, or (2) check the drone.io build
(https://drone.io/bethard/cleartk). The drone.io people are still working on
getting messages sent to Google Groups, so unfortunately at the moment you have
to check that manually. Hopefully in the near future though, we'll get failure
messages sent to cleartk-developers@googlegroups.com
Original comment by steven.b...@gmail.com
on 2 Jul 2013 at 2:50
Original issue reported on code.google.com by
steven.b...@gmail.com
on 29 May 2013 at 11:09