PHP 8.0: silence a deprecation warning instead of not calling the function

JamesHeinrich / getID3

http://www.getid3.org/

Other

1.15k stars 245 forks source link

PHP 8.0: silence a deprecation warning instead of not calling the function #308

Closed jrfnl closed 3 years ago

jrfnl commented 3 years ago

As discussed via email.

This patch should work for the time being (until PHP 9 is released a few years from now), though it would be infinitely better to refactor the code to use the libxml_set_external_entity_loader() function instead. Unfortunately, I don't feel I have enough of the domain specific knowledge needed to be in a good place to create that particular patch, so I will need to leave that future iteration to you or others in the GetID3 team.

StudioMaX commented 3 years ago

For future references, could you please describe what this patch is for and why the current workaround does not work.