JamesHeinrich / getID3

http://www.getid3.org/
Other
1.15k stars 245 forks source link

PHP 8.1: getid3_lib::mb_basename(): fix deprecation notice #335

Closed jrfnl closed 3 years ago

jrfnl commented 3 years ago

The getid3_lib::mb_basename() method calls the PHP native basename() function, the second parameter of which is the optional $suffix parameter which expects a string.

A parameter being optional, however, does not automatically make it nullable.

As of PHP 8.1, passing null to a non-nullable PHP native function will generate a deprecation notice. In this case, this function call yielded a basename(): Passing null to parameter #2 ($suffix) of type string is deprecated notice.

Changing the null default value for the $suffix parameter to an empty string fixes this for most cases without BC-break. Leaving the deprecation warning in place for when calls to the function would pass null for the $suffix so they can adjust their function call.

Refs: