Update module.audio-video.quicktime.php

JamesHeinrich / getID3

http://www.getid3.org/

Other

1.15k stars 245 forks source link

Update module.audio-video.quicktime.php #339

Closed QuixThe2nd closed 3 years ago

QuixThe2nd commented 3 years ago

Fixes following error: Uncaught DivisionByZeroError: Division by zero

StudioMaX commented 3 years ago

Not sure how this happened. playtime_seconds should be a float or int. And there is already !empty($info['playtime_seconds']) in this condition, which means it is not null/''/(int) 0/(float) 0.0/(string) '0'. Do you have information about the value in this variable? Maybe there are some other bug related to playtime_seconds.

JamesHeinrich commented 3 years ago

Can you provide a sample file that triggers a divide-by-zero error?

StudioMaX commented 3 years ago

Looks like this has already been fixed by https://github.com/JamesHeinrich/getID3/pull/291 and https://github.com/JamesHeinrich/getID3/commit/34a0bb2db147633173bcf5db5e72f5195eba3d3e, but there are no new release yet.

JamesHeinrich commented 3 years ago

As mentioned by StudioMaX above this is already fixed, and there v1.9.21 has since been released including that change.