JamesHeinrich / getID3

http://www.getid3.org/
Other
1.15k stars 245 forks source link

several megabyte id3 crashing mysql #340

Closed hayden-t closed 3 years ago

hayden-t commented 3 years ago

I have this odd episode of a show that id3 is generating like a ~4MB meta from. This is going over the max_allowed_packet limit on mysql, the vaule is in quicktime moov. bug.txt

hayden-t commented 3 years ago

I found this setting $getID3->options_audiovideo_quicktime_ReturnAtomData = false; which drops the 'bad' data, maybe it should be by default this considering how 'bad' it is, and that its just going to fill your db with junk.

JamesHeinrich commented 3 years ago

I'm ok with defaulting quicktime.ReturnAtomData=false, changed in https://github.com/JamesHeinrich/getID3/commit/4788e3ed248b0643da73f1b4b2a94e2f52f71e48

hayden-t commented 3 years ago

cheers