JamesHeinrich / getID3

http://www.getid3.org/
Other
1.15k stars 245 forks source link

Work around divide by zero bug in MPEG-2 aspect ratio #359

Closed bvibber closed 2 years ago

bvibber commented 2 years ago

In 9ce8040f I introduced a divide-by-zero bug into the aspect ratio handling for MPEG-2 videos. In production at Wikipedia we've seen a few attempted uploads for files that trigger a divide by zero on the width, which either means corrupt files or something's wrong elsewhere.

Unfortunately our logging doesn't include the files being uploaded, so I don't have a test case to analyze. But this workaround will at least avoid a fatal error that can't be caught.

On our bug tracker: https://phabricator.wikimedia.org/T289189