search

JamesHeinrich / getID3

http://www.getid3.org/
Other
1.13k stars 245 forks source link

Compatibility fix for PHP 5.3 #435

Closed StudioMaX closed 5 months ago

StudioMaX commented 5 months ago

Array dereferencing support was added only with PHP 5.4

JamesHeinrich commented 5 months ago

Thanks. How long should we care about PHP5 compatibility? PHP7 has been out for 8 years now.

StudioMaX commented 5 months ago

The main problem is that in order to at least partially comply with the semver, we cannot remove unsupported PHP versions in the current major version; for this we will need to release a new major or at least 1.10 version. In 2.0 and my local 2.1, I long ago bumped the minimum version to PHP 7.2, but I can’t find the time to finalize 2.1 to a working state, I’m just merging all new commits from 1.9. :)

JamesHeinrich commented 5 months ago

Whenever you're ready for 2.1 I can also increment to 1.10 and match your minimum PHP version.