JamesHeinrich / getID3

http://www.getid3.org/
Other
1.15k stars 245 forks source link

Ignore demos in gitattributes #445

Closed jasonvarga closed 3 months ago

jasonvarga commented 3 months ago

This PR prevents the demos directory being included in archives, which Composer uses.

I see that the directory was re-added in this commit where the question was asked if it causes any problems.

We use this package as a dependency in our own, and it has been flagged by security analysts because of what's in the demos directory. Excluding the demos directory within gitattributes would prevent it from being included via Composer and would satisfy the requirements.

It looks like the demos are disabled because of security issues anyway:

https://github.com/JamesHeinrich/getID3/blob/d0e347f9d501d184436b1c3dc35d0e7dbfada614/demos/demo.browse.php#L15