Fix TypeError for PHP 7.4

JamesHeinrich / phpThumb

phpThumb() - The PHP thumbnail generator

Other

315 stars 141 forks source link

Fix TypeError for PHP 7.4 #218

Closed halftrainedharry closed 9 months ago

halftrainedharry commented 10 months ago

The PR #216 creates a fatal error in PHP 7.4, because the pseudo type mixed was only added in PHP 8.

Fatal error: Uncaught TypeError: Argument 2 passed to phpthumb::__set() must be an instance of mixed, bool given

smg6511 commented 9 months ago

@JamesHeinrich - You likely already know this but, If you intend on continuing support for anything < php 8, this simple fix needs to be implemented. Alternatively, explicitly state that php 7.x is no longer supported. Much appreciate action in either direction sooner than later ;-)

muzzwood commented 9 months ago

Also having the same issue. Would love to see this merged! 🙏🏻

rthrash commented 7 months ago

Hi @JamesHeinrich sorry to bug you on this one but it'd be epic to get a release out with this fix.

JamesHeinrich commented 7 months ago

https://github.com/JamesHeinrich/phpThumb/releases/tag/v1.7.22