search

JamesHenry / typescript-estree

:sparkles: A parser that converts TypeScript source code into an ESTree-compatible form
https://jameshenry.blog
Other
84 stars 13 forks source link

refactor: simplify assigning directive property to nodes #105

Closed armano2 closed 5 years ago

armano2 commented 5 years ago

This PR changes way how directives are assigned.

instead of iterating over nodes 2 times we do all stuff in one run, with that we are able to check ts nodes, and we no longer have to do unnecessary checks.

Typescript has special node for parenthesis

https://github.com/JamesHenry/typescript-estree/pull/103#issuecomment-451773063

JamesHenry commented 5 years ago

Nice solution!

JamesHenry commented 5 years ago

:tada: This PR is included in version 13.6.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: