search

JamesHenry / typescript-estree

:sparkles: A parser that converts TypeScript source code into an ESTree-compatible form
https://jameshenry.blog
Other
84 stars 13 forks source link

chore: add new notes about PRs in babel #106

Closed armano2 closed 5 years ago

armano2 commented 5 years ago

That's a little not related but TS7010 will be reported when noImplictAny option is set.

    /**
     * TypeScript does not report any diagnostics for this file, but Babel throws:
     * [SyntaxError: Unexpected token, expected "{" (2:8)
      1 | class Foo {
    > 2 |   foo?();
        |         ^
      3 |   bar?(): string;
      4 |   private baz?(): string;
      5 | }]
     */
    'class-with-optional-methods', // babel parse errors
JamesHenry commented 5 years ago

@armano2 I don't think we'll ever want to throw on type errors from this parser

armano2 commented 5 years ago

ok, it's just information why :>

JamesHenry commented 5 years ago

:tada: This PR is included in version 13.5.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: