JamesHenry commented 5 years ago

I haven't done this before, so will likely mess it up. Initially copied config file from prettier

j-f1 commented 5 years ago

Looks like you’ve got an error:

X Failed to read file at /home/travis/build/JamesHenry/typescript-estree/coverage/cobertura-coverage.xml

JamesHenry commented 5 years ago

Thanks so much @j-f1 and @armano2 - this is laziest dev work I've ever done, not even bothering to look at the docs of the product I'm adding and let you two find all the issues for me 😂

armano2 commented 5 years ago

looks like its working https://codecov.io/gh/JamesHenry/typescript-estree/pull/114/tree?path=src

JamesHenry commented 5 years ago

Yep I'll just update the coverage level to be appropriate with the starting point

codecov[bot] commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@337f405). Click here to learn what that means. The diff coverage is n/a.

@@           Coverage Diff            @@
##             master    #114   +/-   ##
========================================
  Coverage          ?   93.1%           
========================================
  Files             ?       8           
  Lines             ?    1407           
  Branches          ?     345           
========================================
  Hits              ?    1310           
  Misses            ?      46           
  Partials          ?      51

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 337f405...8075199. Read the comment docs.

armano2 commented 5 years ago

i have few question about this, can we turn off coverage on dev builds, and enable jest ci on ci builds?

yarn test -- --coverage --ci

and in jest.config.js

collectCoverage: false

jest has bug that you can't debug when collectCoverage is set to true.

--ci:

When this option is provided, Jest will assume it is running in a CI environment. This changes the behavior when a new snapshot is encountered. Instead of the regular behavior of storing a new snapshot automatically, it will fail the test

--coverage:

Indicates that test coverage information should be collected and reported in the output.

JamesHenry commented 5 years ago

For sure! Just wanted to make sure I got the infrastructure enabled ASAP - I’m definitely open to any reasonable config changes On Fri, 11 Jan 2019 at 10:13, Armano notifications@github.com wrote:

i have few question about this, can we turn off coverage on dev builds, and enable jest ci on ci builds?

yarn test -- --coverage --ci

and in jest.config.js

collectCoverage: false

jest has bug that you can't debug when collectCoverage is set to true.

--ci:

When this option is provided, Jest will assume it is running in a CI environment. This changes the behavior when a new snapshot is encountered. Instead of the regular behavior of storing a new snapshot automatically, it will fail the test

--coverage:

Indicates that test coverage information should be collected and reported in the output.

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/JamesHenry/typescript-estree/pull/114#issuecomment-453548628, or mute the thread https://github.com/notifications/unsubscribe-auth/AA29q_tCnTqld92a8e6pBEZhvpcfPyH5ks5vCKoRgaJpZM4Z7dUt .

JamesHenry commented 5 years ago

:tada: This PR is included in version 16.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

JamesHenry / typescript-estree

chore: try adding codecov #114

Codecov Report

jest has bug that you can't debug when collectCoverage is set to true.