search

JamesHenry / typescript-estree

:sparkles: A parser that converts TypeScript source code into an ESTree-compatible form
https://jameshenry.blog
Other
84 stars 13 forks source link

feat: update TSIndexSignature node and enable error TS1071 #115

Closed armano2 closed 5 years ago

armano2 commented 5 years ago

This PR align structure of node TSIndexSignature with babel

i was not able to enable alignment tests due to https://github.com/babel/babel/issues/9319

112

codecov[bot] commented 5 years ago

Codecov Report

Merging #115 into master will increase coverage by 0.08%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
+ Coverage   92.83%   92.91%   +0.08%     
==========================================
  Files           8        8              
  Lines        1409     1412       +3     
  Branches      345      346       +1     
==========================================
+ Hits         1308     1312       +4     
  Misses         55       55              
+ Partials       46       45       -1
Impacted Files Coverage Δ
src/semantic-errors.ts 77.77% <ø> (ø) :arrow_up:
src/ast-node-types.ts 100% <100%> (ø) :arrow_up:
src/convert.ts 93.45% <100%> (+0.15%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9298d8f...661a704. Read the comment docs.

JamesHenry commented 5 years ago

:tada: This PR is included in version 16.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: