Codecov Report

Merging #118 into master will increase coverage by 0.16%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #118      +/-   ##
==========================================
+ Coverage   93.05%   93.22%   +0.16%     
==========================================
  Files           8        8              
  Lines        1412     1357      -55     
  Branches      346      319      -27     
==========================================
- Hits         1314     1265      -49     
+ Misses         54       51       -3     
+ Partials       44       41       -3

Impacted Files	Coverage Δ
src/node-utils.ts	`95.29% <ø> (-0.29%)`	:arrow_down:
src/convert.ts	`93.86% <100%> (+0.4%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 868e760...3d6ad10. Read the comment docs.

armano2 commented 5 years ago

ok, its ready

should i remove no longer used helper functions from utils?

findAncestorOfKind
findChildOfKind
findFirstMatchingAncestor

JamesHenry commented 5 years ago

Merged in the extra test cases you made, sorry for the conflicts

armano2 commented 5 years ago

nah thats was a point, to make this PR reflect only actual changes.

what i should do with those utils functions?

JamesHenry commented 5 years ago

Sure you can go ahead and remove them, we can always dig them out of the git history if we need them again!

JamesHenry commented 5 years ago

:tada: This PR is included in version 17.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

JamesHenry / typescript-estree

feat: change logic of distinguishing patterns from statements #118

Codecov Report