armano2 commented 5 years ago

benefits: tree-shaking and faster access to imports

i'm going to wait with changing converter after #120 will be finished

import * as nodeUtils from './node-utils';

codecov[bot] commented 5 years ago

Codecov Report

Merging #121 into master will increase coverage by 0.14%. The diff coverage is 97.29%.

@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
+ Coverage    93.2%   93.34%   +0.14%     
==========================================
  Files           8        8              
  Lines        1368     1398      +30     
  Branches      324      324              
==========================================
+ Hits         1275     1305      +30     
  Misses         51       51              
  Partials       42       42

Impacted Files	Coverage Δ
src/parser.ts	`78.5% <100%> (ø)`	:arrow_up:
src/node-utils.ts	`96% <100%> (+0.7%)`	:arrow_up:
src/ast-converter.ts	`100% <100%> (ø)`	:arrow_up:
src/convert-comments.ts	`96.07% <100%> (ø)`	:arrow_up:
src/convert.ts	`93.82% <95.77%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7176619...6e0e866. Read the comment docs.

JamesHenry commented 5 years ago

No rush at all, I'll just wait until you let me know this PR is ready. I was literally thinking about this change just this morning - another legacy of the codebase being originally a pure JS package

JamesHenry commented 5 years ago

:tada: This PR is included in version 18.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

JamesHenry / typescript-estree

refactor: migrate node-utils from commonjs to es6 module #121

Codecov Report